Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nbstore): add doc sync state #9131

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat(nbstore): add doc sync state #9131

merged 1 commit into from
Dec 18, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 12, 2024

No description provided.

Copy link
Member Author

EYHN commented Dec 12, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 19.44444% with 29 lines in your changes missing coverage. Please review.

Project coverage is 65.70%. Comparing base (8374346) to head (3fddf05).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/common/nbstore/src/sync/doc/peer.ts 6.25% 15 Missing ⚠️
packages/common/nbstore/src/sync/doc/index.ts 28.57% 10 Missing ⚠️
packages/common/nbstore/src/sync/index.ts 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9131      +/-   ##
==========================================
- Coverage   65.78%   65.70%   -0.09%     
==========================================
  Files         727      727              
  Lines       41382    41417      +35     
  Branches     4090     4095       +5     
==========================================
- Hits        27225    27211      -14     
- Misses      13725    13773      +48     
- Partials      432      433       +1     
Flag Coverage Δ
server-test 78.20% <ø> (-0.07%) ⬇️
unittest 35.81% <19.44%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/feat/awareness branch from 515b4b4 to 971daf9 Compare December 17, 2024 02:35
@EYHN EYHN force-pushed the eyhn/feat/awareness branch from 971daf9 to 0073358 Compare December 17, 2024 02:56
@EYHN EYHN force-pushed the eyhn/feat/awareness branch from 0073358 to 13700b3 Compare December 17, 2024 03:20
@EYHN EYHN changed the base branch from eyhn/feat/awareness to graphite-base/9131 December 17, 2024 04:37
@EYHN EYHN force-pushed the graphite-base/9131 branch from 13700b3 to ffa0231 Compare December 17, 2024 04:52
@EYHN EYHN changed the base branch from graphite-base/9131 to canary December 17, 2024 04:52
@EYHN EYHN force-pushed the eyhn/sync-state branch 2 times, most recently from 9a0b103 to 9d0390a Compare December 17, 2024 05:30
Copy link

graphite-app bot commented Dec 18, 2024

Merge activity

@graphite-app graphite-app bot merged commit 3fddf05 into canary Dec 18, 2024
47 checks passed
@graphite-app graphite-app bot deleted the eyhn/sync-state branch December 18, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants