Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nbstore): new doc sync engine #8918

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Nov 25, 2024

No description provided.

@EYHN EYHN marked this pull request as ready for review November 25, 2024 12:11
Copy link

graphite-app bot commented Nov 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Nov 25, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the test Related to test cases label Nov 25, 2024
@EYHN EYHN changed the title feat(nbstore): new sync engine feat(nbstore): new doc sync engine Nov 25, 2024
Copy link

nx-cloud bot commented Nov 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f54f6e8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 63.50148% with 123 lines in your changes missing coverage. Please review.

Project coverage is 65.21%. Comparing base (fafacdb) to head (f54f6e8).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/common/nbstore/src/sync/doc/peer.ts 61.68% 68 Missing and 14 partials ⚠️
...ackages/common/nbstore/src/utils/priority-queue.ts 68.75% 7 Missing and 3 partials ⚠️
packages/common/nbstore/src/utils/clock.ts 56.25% 5 Missing and 2 partials ⚠️
...ckages/common/nbstore/src/connection/connection.ts 33.33% 5 Missing and 1 partial ⚠️
packages/common/nbstore/src/impls/idb/sync.ts 53.84% 4 Missing and 2 partials ⚠️
...s/common/nbstore/src/utils/async-priority-queue.ts 75.00% 3 Missing and 2 partials ⚠️
packages/common/nbstore/src/impls/idb/doc.ts 66.66% 1 Missing and 2 partials ⚠️
...kages/common/nbstore/src/utils/throw-if-aborted.ts 50.00% 1 Missing and 1 partial ⚠️
packages/common/nbstore/src/storage/history.ts 0.00% 1 Missing ⚠️
packages/common/nbstore/src/sync/index.ts 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8918      +/-   ##
==========================================
- Coverage   65.38%   65.21%   -0.17%     
==========================================
  Files         679      701      +22     
  Lines       38767    39391     +624     
  Branches     3670     3770     +100     
==========================================
+ Hits        25346    25689     +343     
- Misses      13048    13290     +242     
- Partials      373      412      +39     
Flag Coverage Δ
server-test 77.39% <ø> (-0.07%) ⬇️
unittest 35.81% <63.50%> (+1.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Dec 2, 2024

Merge activity

  • Dec 2, 1:51 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 2, 2:19 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Lint', 'E2E Test (1)', 'E2E Test (2)', 'E2E Test (3)', 'E2E Test (4)', 'E2E Test (5)', 'E2E Mobile Test (1)', 'E2E Mobile Test (2)', 'E2E Mobile Test (3)', 'E2E Mobile Test (4)', 'E2E Mobile Test (5)', 'Build @affine/electron renderer', 'test-build-mobile-app / build-ios-web', 'test-build-mobile-app / build-android-web', 'Unit Test', 'Server Test', 'Server E2E Test 1/3', 'Server E2E Test 2/3', 'Server E2E Test 3/3', 'Server Desktop E2E Test').
  • Dec 3, 1:50 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Dec 7, 3:04 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 7, 3:21 AM EST: A user merged this pull request with the Graphite merge queue.

EYHN added a commit that referenced this pull request Dec 3, 2024
@EYHN EYHN force-pushed the eyhn/feat/nb-sync branch from 9f35c8b to 6a4c994 Compare December 3, 2024 07:31
EYHN added a commit that referenced this pull request Dec 4, 2024
@EYHN EYHN force-pushed the eyhn/feat/nb-sync branch from 6a4c994 to f461a56 Compare December 4, 2024 08:44
EYHN added a commit that referenced this pull request Dec 6, 2024
@EYHN EYHN force-pushed the eyhn/feat/nb-sync branch from f461a56 to 03abb75 Compare December 6, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants