Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nbstore): better doc sync logic #9037

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 6, 2024

No description provided.

Copy link

graphite-app bot commented Dec 6, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Dec 6, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@EYHN EYHN marked this pull request as ready for review December 6, 2024 00:46
Copy link

nx-cloud bot commented Dec 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 35edf38. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 63.04348% with 34 lines in your changes missing coverage. Please review.

Project coverage is 65.62%. Comparing base (0a7a2c3) to head (35edf38).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/common/nbstore/src/sync/doc/peer.ts 45.00% 7 Missing and 4 partials ⚠️
packages/common/nbstore/src/impls/idb/sync.ts 30.00% 6 Missing and 1 partial ⚠️
packages/common/nbstore/src/impls/idb/doc.ts 60.00% 6 Missing ⚠️
packages/common/nbstore/src/impls/idb/lock.ts 85.00% 5 Missing and 1 partial ⚠️
packages/common/nbstore/src/impls/idb/db.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9037      +/-   ##
==========================================
- Coverage   65.69%   65.62%   -0.07%     
==========================================
  Files         712      713       +1     
  Lines       40665    40715      +50     
  Branches     3919     3930      +11     
==========================================
+ Hits        26715    26721       +6     
- Misses      13534    13579      +45     
+ Partials      416      415       -1     
Flag Coverage Δ
server-test 77.70% <ø> (ø)
unittest 35.83% <63.04%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/feat/better-sync branch from 234ead5 to 4e58d3e Compare December 7, 2024 08:01
@EYHN EYHN changed the base branch from eyhn/feat/awareness to eyhn/feat/nb-blob-sync December 7, 2024 08:01
@EYHN EYHN force-pushed the eyhn/feat/better-sync branch from 4e58d3e to 6ec4b89 Compare December 7, 2024 08:03
@EYHN EYHN changed the base branch from eyhn/feat/nb-blob-sync to graphite-base/9037 December 7, 2024 08:05
Copy link

graphite-app bot commented Dec 7, 2024

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/9037 to canary December 7, 2024 08:22
@EYHN EYHN force-pushed the eyhn/feat/better-sync branch from a0bf58c to 35edf38 Compare December 10, 2024 06:49
@graphite-app graphite-app bot merged commit 35edf38 into canary Dec 10, 2024
47 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/better-sync branch December 10, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants