Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nbstore): add blob sync #8996

Merged
merged 1 commit into from
Dec 7, 2024
Merged

feat(nbstore): add blob sync #8996

merged 1 commit into from
Dec 7, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 3, 2024

No description provided.

@EYHN EYHN marked this pull request as ready for review December 3, 2024 07:31
Copy link

graphite-app bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Dec 3, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added mod:infra Environment related issues and discussions test Related to test cases labels Dec 3, 2024
@EYHN EYHN force-pushed the eyhn/feat/nb-blob-sync branch from 5df6caf to 42ec88a Compare December 3, 2024 07:32
Copy link

nx-cloud bot commented Dec 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7225f59. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 62.12121% with 25 lines in your changes missing coverage. Please review.

Project coverage is 65.83%. Comparing base (f54f6e8) to head (7225f59).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/common/nbstore/src/sync/blob/index.ts 61.36% 14 Missing and 3 partials ⚠️
packages/common/nbstore/src/sync/doc/peer.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8996      +/-   ##
==========================================
+ Coverage   65.21%   65.83%   +0.61%     
==========================================
  Files         701      702       +1     
  Lines       39391    39450      +59     
  Branches     3770     3817      +47     
==========================================
+ Hits        25689    25971     +282     
+ Misses      13290    13060     -230     
- Partials      412      419       +7     
Flag Coverage Δ
server-test 78.13% <ø> (+0.73%) ⬆️
unittest 36.07% <62.12%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:infra Environment related issues and discussions test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants