Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nbstore): add blob sync frontend #9084

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 10, 2024

No description provided.

Copy link

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Dec 10, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Dec 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0c0722c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 65.41%. Comparing base (a67fbc9) to head (0c0722c).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/common/nbstore/src/sync/blob/index.ts 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9084      +/-   ##
==========================================
- Coverage   65.89%   65.41%   -0.49%     
==========================================
  Files         715      715              
  Lines       41108    41121      +13     
  Branches     4018     3983      -35     
==========================================
- Hits        27090    26900     -190     
- Misses      13591    13797     +206     
+ Partials      427      424       -3     
Flag Coverage Δ
server-test 77.42% <ø> (-0.59%) ⬇️
unittest 35.93% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/sync-frontend branch 2 times, most recently from 4f16cd2 to 4ec8459 Compare December 10, 2024 07:05
@EYHN EYHN force-pushed the eyhn/blob-sync-frontend branch from c567123 to 77a6b5a Compare December 10, 2024 07:05
@EYHN EYHN force-pushed the eyhn/sync-frontend branch from 4ec8459 to 059defe Compare December 10, 2024 08:29
@EYHN EYHN force-pushed the eyhn/blob-sync-frontend branch from 77a6b5a to 9099d33 Compare December 10, 2024 08:29
@EYHN EYHN marked this pull request as ready for review December 10, 2024 08:29
@EYHN EYHN changed the title feat(nbstore): blob sync frontend feat(nbstore): add blob sync frontend Dec 10, 2024
@EYHN EYHN changed the base branch from eyhn/sync-frontend to graphite-base/9084 December 11, 2024 07:53
@EYHN EYHN force-pushed the eyhn/blob-sync-frontend branch from 9099d33 to f0d39d5 Compare December 11, 2024 08:09
@EYHN EYHN force-pushed the graphite-base/9084 branch from 059defe to 331e674 Compare December 11, 2024 08:09
@EYHN EYHN changed the base branch from graphite-base/9084 to canary December 11, 2024 08:10
@EYHN EYHN force-pushed the eyhn/blob-sync-frontend branch from f0d39d5 to 989ef84 Compare December 11, 2024 08:10
Copy link

graphite-app bot commented Dec 11, 2024

Merge activity

@graphite-app graphite-app bot merged commit 0c0722c into canary Dec 11, 2024
47 checks passed
@graphite-app graphite-app bot deleted the eyhn/blob-sync-frontend branch December 11, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants