Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nbstore): add awareness storage&sync&frontend #9016

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 4, 2024

No description provided.

Copy link

graphite-app bot commented Dec 4, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

EYHN commented Dec 4, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 23 lines in your changes missing coverage. Please review.

Project coverage is 65.42%. Comparing base (36ac793) to head (ffa0231).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...n/nbstore/src/impls/broadcast-channel/awareness.ts 56.25% 13 Missing and 1 partial ⚠️
packages/common/nbstore/src/frontend/awareness.ts 76.19% 4 Missing and 1 partial ⚠️
...mon/nbstore/src/impls/broadcast-channel/channel.ts 40.00% 3 Missing ⚠️
...ackages/common/nbstore/src/sync/awareness/index.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9016      +/-   ##
==========================================
+ Coverage   65.37%   65.42%   +0.04%     
==========================================
  Files         722      727       +5     
  Lines       41203    41270      +67     
  Branches     4041     4052      +11     
==========================================
+ Hits        26938    27002      +64     
- Misses      13835    13836       +1     
- Partials      430      432       +2     
Flag Coverage Δ
server-test 77.80% <ø> (+0.06%) ⬆️
unittest 35.87% <66.66%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/feat/nb-blob-sync branch from 4d06691 to aa67016 Compare December 6, 2024 00:46
@EYHN EYHN force-pushed the eyhn/feat/awareness branch from 5cf626f to 7a90114 Compare December 6, 2024 00:46
@EYHN EYHN marked this pull request as ready for review December 6, 2024 00:46
@graphite-app graphite-app bot requested review from CatsJuice, JimmFly, forehalo and pengx17 and removed request for CatsJuice December 6, 2024 00:46
@EYHN EYHN force-pushed the eyhn/feat/nb-blob-sync branch from aa67016 to fe9f252 Compare December 6, 2024 01:20
@EYHN EYHN force-pushed the eyhn/feat/awareness branch from 7a90114 to 5d261f4 Compare December 6, 2024 01:20
@EYHN EYHN changed the base branch from eyhn/feat/nb-blob-sync to graphite-base/9016 December 7, 2024 08:05
@EYHN EYHN force-pushed the eyhn/feat/awareness branch from 5d261f4 to a27e7b8 Compare December 7, 2024 08:22
@EYHN EYHN force-pushed the graphite-base/9016 branch from fe9f252 to 7225f59 Compare December 7, 2024 08:22
@EYHN EYHN force-pushed the eyhn/feat/awareness branch from baecc13 to 1045cee Compare December 11, 2024 12:39
@EYHN EYHN changed the base branch from canary to eyhn/blob-sync-frontend December 11, 2024 12:39
@EYHN EYHN changed the base branch from eyhn/blob-sync-frontend to graphite-base/9016 December 11, 2024 12:39
@EYHN EYHN force-pushed the eyhn/feat/awareness branch from 1045cee to 0357f3a Compare December 11, 2024 12:53
@EYHN EYHN force-pushed the graphite-base/9016 branch from 989ef84 to 0c0722c Compare December 11, 2024 12:53
@EYHN EYHN changed the base branch from graphite-base/9016 to canary December 11, 2024 12:54
@EYHN EYHN force-pushed the eyhn/feat/awareness branch 2 times, most recently from 92b1225 to c019edf Compare December 12, 2024 07:58
@github-actions github-actions bot added the test Related to test cases label Dec 12, 2024
@EYHN EYHN force-pushed the eyhn/feat/awareness branch from 404b063 to 36c7d1f Compare December 12, 2024 10:47
@EYHN EYHN changed the title feat(nbstore): add awareness storage feat(nbstore): add awareness storage&sync&frontend Dec 12, 2024
@EYHN EYHN force-pushed the eyhn/feat/awareness branch from 36c7d1f to 515b4b4 Compare December 12, 2024 10:57
Copy link

graphite-app bot commented Dec 16, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/feat/awareness branch 3 times, most recently from 0073358 to 13700b3 Compare December 17, 2024 03:20
@EYHN EYHN force-pushed the eyhn/feat/awareness branch from 13700b3 to ffa0231 Compare December 17, 2024 04:37
@graphite-app graphite-app bot merged commit ffa0231 into canary Dec 17, 2024
47 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/awareness branch December 17, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants