Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pdf module #8720

Merged

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Nov 6, 2024

What's Changed?

  • makes pdf a universal service
  • supports 2 working modes
    1. shared worker: use unified worker to process data, maybe scope it to workspace
    2. worker: a pdf uses a separate worker
  • fallback: SharedWorker -> Worker

Closes: AF-1622

Copy link

graphite-app bot commented Nov 6, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Nov 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Nov 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 14ddffd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx test:coverage @affine/monorepo

Sent with 💌 from NxCloud.

@fundon fundon force-pushed the fundon/10_21_feat_pdf_preview branch from 730687d to e8eeca3 Compare November 8, 2024 14:44
@fundon fundon force-pushed the fundon/11_06_refactor_pdf_module branch from 14ddffd to 7f5c1ad Compare November 8, 2024 14:44
@github-actions github-actions bot added mod:i18n Related to i18n mod:component labels Nov 8, 2024
@fundon fundon merged commit 7f5c1ad into fundon/10_21_feat_pdf_preview Nov 8, 2024
16 of 32 checks passed
@fundon fundon deleted the fundon/11_06_refactor_pdf_module branch November 8, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant