-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): patch pdf viewer #8782
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cd74d55. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fundon/10_21_feat_pdf_preview #8782 +/- ##
=================================================================
- Coverage 70.25% 70.19% -0.06%
=================================================================
Files 549 549
Lines 33892 33898 +6
Branches 3042 3043 +1
=================================================================
- Hits 23812 23796 -16
- Misses 9710 9731 +21
- Partials 370 371 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a3e110a
to
032f22a
Compare
|
||
render = effect( | ||
switchMap((opts: Omit<RenderPageOpts, 'pageNum'>) => | ||
this.props.pdf.renderer.ob$('render', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think fromPromise(renderer.call('render'))
is more readable
No description provided.