Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): patch pdf viewer #8782

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

forehalo
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Nov 11, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:infra Environment related issues and discussions docs Improvements or additions to documentation test Related to test cases app:core labels Nov 11, 2024
Copy link
Member Author

forehalo commented Nov 11, 2024

Copy link

nx-cloud bot commented Nov 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cd74d55. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.19%. Comparing base (032f22a) to head (cd74d55).
Report is 2 commits behind head on fundon/10_21_feat_pdf_preview.

Files with missing lines Patch % Lines
packages/common/infra/src/op/message.ts 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           fundon/10_21_feat_pdf_preview    #8782      +/-   ##
=================================================================
- Coverage                          70.25%   70.19%   -0.06%     
=================================================================
  Files                                549      549              
  Lines                              33892    33898       +6     
  Branches                            3042     3043       +1     
=================================================================
- Hits                               23812    23796      -16     
- Misses                              9710     9731      +21     
- Partials                             370      371       +1     
Flag Coverage Δ
server-test 77.12% <ø> (-0.07%) ⬇️
unittest 45.87% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


render = effect(
switchMap((opts: Omit<RenderPageOpts, 'pageNum'>) =>
this.props.pdf.renderer.ob$('render', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think fromPromise(renderer.call('render')) is more readable

@fundon fundon merged commit cd74d55 into fundon/10_21_feat_pdf_preview Nov 12, 2024
41 of 43 checks passed
@fundon fundon deleted the 61/patch-pdf branch November 12, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core docs Improvements or additions to documentation mod:infra Environment related issues and discussions test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants