-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: pdf viewer components #8784
refactor: pdf viewer components #8784
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e2c5390. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 61/patch-pdf #8784 +/- ##
=============================================
Coverage 70.25% 70.25%
=============================================
Files 549 549
Lines 33898 33898
Branches 3043 3043
=============================================
Hits 23814 23814
Misses 9713 9713
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e2a2988
to
2ff9e6d
Compare
2ff9e6d
to
3061337
Compare
let rc = this.pages.get(key); | ||
|
||
console.log(key, rc); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This console.log
statement appears to be a debugging artifact and should be removed before merging to production. While logging is valuable during development, keeping debug logs in production code can impact performance and pollute logs with unnecessary information.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
3061337
to
4afc004
Compare
4afc004
to
e2c5390
Compare
No description provided.