Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pdf viewer components #8784

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Nov 11, 2024

No description provided.

Copy link

graphite-app bot commented Nov 11, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Nov 11, 2024

Copy link

nx-cloud bot commented Nov 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e2c5390. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.25%. Comparing base (fbfc9e8) to head (e2c5390).
Report is 1 commits behind head on 61/patch-pdf.

Additional details and impacted files
@@              Coverage Diff              @@
##           61/patch-pdf    #8784   +/-   ##
=============================================
  Coverage         70.25%   70.25%           
=============================================
  Files               549      549           
  Lines             33898    33898           
  Branches           3043     3043           
=============================================
  Hits              23814    23814           
  Misses             9713     9713           
  Partials            371      371           
Flag Coverage Δ
server-test 77.18% <ø> (ø)
unittest 45.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/11_12_refactor_pdf_viewer_components branch from e2a2988 to 2ff9e6d Compare November 11, 2024 22:20
@github-actions github-actions bot added the test Related to test cases label Nov 11, 2024
@fundon fundon force-pushed the fundon/11_12_refactor_pdf_viewer_components branch from 2ff9e6d to 3061337 Compare November 11, 2024 22:51
let rc = this.pages.get(key);

console.log(key, rc);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This console.log statement appears to be a debugging artifact and should be removed before merging to production. While logging is valuable during development, keeping debug logs in production code can impact performance and pollute logs with unnecessary information.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@fundon fundon force-pushed the fundon/11_12_refactor_pdf_viewer_components branch from 4afc004 to e2c5390 Compare November 11, 2024 22:56
@fundon fundon marked this pull request as ready for review November 12, 2024 06:06
@graphite-app graphite-app bot requested review from pengx17, EYHN, JimmFly, CatsJuice and forehalo and removed request for pengx17 November 12, 2024 06:07
@fundon fundon merged commit e2c5390 into 61/patch-pdf Nov 12, 2024
43 of 46 checks passed
@fundon fundon deleted the fundon/11_12_refactor_pdf_viewer_components branch November 12, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant