Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pdf viewer using op and service #8764

Merged

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Nov 10, 2024

No description provided.

Copy link

graphite-app bot commented Nov 10, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:infra Environment related issues and discussions docs Improvements or additions to documentation app:core labels Nov 10, 2024
@fundon fundon mentioned this pull request Nov 10, 2024
7 tasks
Copy link
Contributor Author

fundon commented Nov 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Nov 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3b60650. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.23%. Comparing base (a22d17f) to head (3b60650).
Report is 1 commits behind head on fundon/10_21_feat_pdf_preview.

Files with missing lines Patch % Lines
packages/common/infra/src/op/message.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           fundon/10_21_feat_pdf_preview    #8764      +/-   ##
=================================================================
+ Coverage                          70.17%   70.23%   +0.05%     
=================================================================
  Files                                549      549              
  Lines                              33883    33884       +1     
  Branches                            3042     3042              
=================================================================
+ Hits                               23779    23799      +20     
+ Misses                              9735     9716      -19     
  Partials                             369      369              
Flag Coverage Δ
server-test 77.18% <ø> (+0.06%) ⬆️
unittest 45.73% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/11_09_refactor_worker_using_op branch from 21944c7 to 3b60650 Compare November 10, 2024 19:17
@fundon fundon marked this pull request as ready for review November 10, 2024 19:20
@graphite-app graphite-app bot requested review from JimmFly, pengx17, CatsJuice, forehalo and EYHN and removed request for JimmFly November 10, 2024 19:20
@fundon fundon merged commit 3b60650 into fundon/10_21_feat_pdf_preview Nov 10, 2024
33 of 35 checks passed
@fundon fundon deleted the fundon/11_09_refactor_worker_using_op branch November 10, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core docs Improvements or additions to documentation mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant