-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): pdf embed view component #8671
base: canary
Are you sure you want to change the base?
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bec5e53. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #8671 +/- ##
==========================================
- Coverage 65.74% 65.71% -0.03%
==========================================
Files 706 709 +3
Lines 40541 40578 +37
Branches 3898 3906 +8
==========================================
+ Hits 26652 26665 +13
- Misses 13473 13496 +23
- Partials 416 417 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
90f0665
to
facb69a
Compare
packages/frontend/core/src/components/attachment-viewer/embed/index.tsx
Outdated
Show resolved
Hide resolved
facb69a
to
c53d8cf
Compare
c53d8cf
to
0bed2a8
Compare
c7ca99b
to
7910f20
Compare
0bed2a8
to
9cdb92e
Compare
7910f20
to
25086b9
Compare
9cdb92e
to
14a1b25
Compare
14a1b25
to
e74620c
Compare
e62030d
to
dc4fa3d
Compare
dc4fa3d
to
e4393af
Compare
e4393af
to
bb080dd
Compare
bb080dd
to
befe0a8
Compare
befe0a8
to
3a018ce
Compare
3a018ce
to
dedec70
Compare
dedec70
to
cff7d0c
Compare
cff7d0c
to
43d907c
Compare
43d907c
to
bec5e53
Compare
Closes: AF-1445
Upstreams: toeverything/blocksuite#8658, toeverything/blocksuite#8752
What's Changed
IntersectionObserver
to determine lazy loadingPDFViewerEmbedded
component