Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): pdf embed view component #8671

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Nov 1, 2024

Closes: AF-1445
Upstreams: toeverything/blocksuite#8658, toeverything/blocksuite#8752

What's Changed

  • uses IntersectionObserver to determine lazy loading
  • adds PDFViewerEmbedded component
  • automatically shut down workers when out of view
🎥 Video uploaded on Graphite:

Copy link

graphite-app bot commented Nov 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

fundon commented Nov 1, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon mentioned this pull request Nov 1, 2024
7 tasks
Copy link

nx-cloud bot commented Nov 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bec5e53. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 22 lines in your changes missing coverage. Please review.

Project coverage is 65.71%. Comparing base (1514e12) to head (bec5e53).
Report is 4 commits behind head on canary.

Files with missing lines Patch % Lines
...ontend/component/src/utils/observe-intersection.ts 21.42% 21 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8671      +/-   ##
==========================================
- Coverage   65.74%   65.71%   -0.03%     
==========================================
  Files         706      709       +3     
  Lines       40541    40578      +37     
  Branches     3898     3906       +8     
==========================================
+ Hits        26652    26665      +13     
- Misses      13473    13496      +23     
- Partials      416      417       +1     
Flag Coverage Δ
server-test 77.65% <ø> (+<0.01%) ⬆️
unittest 36.08% <21.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from facb69a to c53d8cf Compare November 4, 2024 17:02
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from c53d8cf to 0bed2a8 Compare November 4, 2024 17:20
@fundon fundon force-pushed the fundon/10_21_feat_pdf_preview branch from c7ca99b to 7910f20 Compare November 5, 2024 03:12
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from 0bed2a8 to 9cdb92e Compare November 5, 2024 03:12
@fundon fundon force-pushed the fundon/10_21_feat_pdf_preview branch from 7910f20 to 25086b9 Compare November 5, 2024 06:18
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from 9cdb92e to 14a1b25 Compare November 5, 2024 06:18
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from 14a1b25 to e74620c Compare November 5, 2024 06:50
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from e62030d to dc4fa3d Compare November 14, 2024 20:37
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from dc4fa3d to e4393af Compare November 15, 2024 00:06
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from e4393af to bb080dd Compare November 15, 2024 23:09
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from bb080dd to befe0a8 Compare November 15, 2024 23:23
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from befe0a8 to 3a018ce Compare November 15, 2024 23:28
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from 3a018ce to dedec70 Compare December 10, 2024 01:45
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from dedec70 to cff7d0c Compare December 10, 2024 01:51
@fundon fundon force-pushed the fundon/11_02_pdf_embed_view branch from cff7d0c to 43d907c Compare December 10, 2024 02:15
@fundon fundon changed the title feat: pdf embed view component feat(core): pdf embed view component Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:component mod:dev mod:env mod:i18n Related to i18n mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant