-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve pdf preview #8615
chore: improve pdf preview #8615
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0d57b01. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fundon/10_21_feat_pdf_preview #8615 +/- ##
=================================================================
+ Coverage 70.11% 70.30% +0.18%
=================================================================
Files 536 536
Lines 33700 33792 +92
Branches 3023 3088 +65
=================================================================
+ Hits 23628 23756 +128
+ Misses 9717 9681 -36
Partials 355 355
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2d34435
to
b36bff9
Compare
b36bff9
to
d77e2f1
Compare
d77e2f1
to
aaea9d6
Compare
67e0b8c
to
6c1d599
Compare
aaea9d6
to
701d02a
Compare
6c1d599
to
3472add
Compare
701d02a
to
c0d6db6
Compare
bf29260
to
4f97399
Compare
c0d6db6
to
ec799f1
Compare
c8661b8
to
5c04135
Compare
5c04135
to
5cb1c8e
Compare
5cb1c8e
to
78ae568
Compare
78ae568
to
04b70d8
Compare
affine-toeverythingBundle maindiff ------------------- Bundle Size Diff -------------------------
@@ EntryPoint: app @@
## canary …e_pdf_preview +/- ##
===================================================================
< Bundle 22.6 MB 24.1 MB +1.45 MB(+6.42%)
< Initial JS 9.63 MB 9.89 MB +264 kB(+2.74%)
> Initial CSS 256 kB 241 kB -14.7 kB(-5.76%)
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets 75 84 +9
< Chunks 73 82 +9
< Packages 305 308 +3
= Duplicates 23 23
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries
! Separate mixed content assets files
! Avoid cache wasting
|
04b70d8
to
0d57b01
Compare
ImageBitmap
ImageBitmap