Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More small redesign changes #609

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

mattias800
Copy link
Collaborator

@mattias800 mattias800 commented Oct 2, 2023

  • Remove all usage of FA icons in components, except for sort order (we don't have equivalent Stena icons yet).
  • Update peer dependencies to FA to be @fortawesome/fontawesome-svg-core instead of the icon library packages.
  • Fix gap and width of month picker and year picker, no longer too narrow for increased width of the buttons.
  • Update bread crumbs as per design. Icon stenaLineSlash is not correct, but fixed icon is not included in this update.
  • Horizontal padding in buttons is now 24px if they only have a label, 16px otherwise.
  • Fixed height of standard size button, is now 32px.
  • Checkbox and Radiobutton now uses modern-blue instead of core-blue, as per design.
  • Update PageHeader with new design, which is aligned with NavBar.
  • Inputs now have border radius 4px, as per design.
  • Update TextInput variants. Variants no longer have border, as per design. Normal and loading still has border.
  • Update colors of TextInput variants.
  • NavBarHeading is now h1 level (but still has h4 design).
  • PageHeading has default h2 level, but can still be changed.

PageHeader

image

TextInput

image

Version

Published prerelease version: v19.0.0-next.6

Changelog

💥 Breaking Change

  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/panels

🐛 Bug Fix

  • Add prerelease step for next branch #602 (@lindskogen)
  • @stenajs-webui/calendar, @stenajs-webui/elements, @stenajs-webui/filter, @stenajs-webui/forms, @stenajs-webui/grid-export, @stenajs-webui/grid, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/elements
  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/filter, @stenajs-webui/modal, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/theme
  • @stenajs-webui/filter
  • @stenajs-webui/elements, @stenajs-webui/panels, @stenajs-webui/theme, @stenajs-webui/tooltip
  • @stenajs-webui/elements, @stenajs-webui/modal, @stenajs-webui/panels
  • @stenajs-webui/elements, @stenajs-webui/theme

Authors: 4

…we don't have equivalent Stena icons yet).

- Update peer dependencies to FA to be `@fortawesome/fontawesome-svg-core` instead of the icon library packages.
- Fix gap and width of month picker and year picker, no longer too narrow for increased width of the buttons.
- Update bread crumbs as per design. Icon stenaLineSlash is not correct, but fixed icon is not included in this update.
- Horizontal padding in buttons is now 24px if they only have a label, 16px otherwise.
- Fixed height of standard size button, is now 32px.
- Checkbox and Radiobutton now uses modern-blue instead of core-blue, as per design.
- Update PageHeader with new design, which is aligned with NavBar.
- Inputs now have border radius 4px, as per design.
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Size Change: 0 B

Total Size: 352 kB

ℹ️ View Unchanged
Filename Size
packages/calendar/dist/index.es.js 15 kB
packages/calendar/dist/index.js 12.9 kB
packages/core/dist/index.es.js 4.98 kB
packages/core/dist/index.js 4.67 kB
packages/elements/dist/index.es.js 108 kB
packages/elements/dist/index.js 106 kB
packages/filter/dist/index.es.js 3.82 kB
packages/filter/dist/index.js 3.31 kB
packages/forms/dist/index.es.js 6.72 kB
packages/forms/dist/index.js 6.22 kB
packages/grid-export/dist/index.es.js 2.04 kB
packages/grid-export/dist/index.js 1.99 kB
packages/grid/dist/index.es.js 16 kB
packages/grid/dist/index.js 13.8 kB
packages/input-mask/dist/index.es.js 804 B
packages/input-mask/dist/index.js 735 B
packages/modal/dist/index.es.js 3.05 kB
packages/modal/dist/index.js 2.86 kB
packages/panels/dist/index.es.js 8.04 kB
packages/panels/dist/index.js 7.33 kB
packages/redux/dist/index.es.js 3.06 kB
packages/redux/dist/index.js 2.75 kB
packages/select/dist/index.es.js 4.02 kB
packages/select/dist/index.js 3.65 kB
packages/theme/dist/index.es.js 1.93 kB
packages/theme/dist/index.js 1.99 kB
packages/tooltip/dist/index.es.js 2.91 kB
packages/tooltip/dist/index.js 2.72 kB

compressed-size-action

Copy link
Collaborator

@lindskogen lindskogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and questions 😊

…esign. Normal and loading still has border.

- Update colors of TextInput variants.
- NavBarHeading is now h1 level (but still has h4 design).
- PageHeading has default h2 level, but can still be changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants