-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More small redesign changes #609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…we don't have equivalent Stena icons yet). - Update peer dependencies to FA to be `@fortawesome/fontawesome-svg-core` instead of the icon library packages. - Fix gap and width of month picker and year picker, no longer too narrow for increased width of the buttons. - Update bread crumbs as per design. Icon stenaLineSlash is not correct, but fixed icon is not included in this update. - Horizontal padding in buttons is now 24px if they only have a label, 16px otherwise. - Fixed height of standard size button, is now 32px. - Checkbox and Radiobutton now uses modern-blue instead of core-blue, as per design. - Update PageHeader with new design, which is aligned with NavBar. - Inputs now have border radius 4px, as per design.
mattias800
requested review from
lindskogen,
nikteg,
esepato and
AugustasFriend
October 2, 2023 12:06
Size Change: 0 B Total Size: 352 kB ℹ️ View Unchanged
|
lindskogen
reviewed
Oct 2, 2023
lindskogen
reviewed
Oct 2, 2023
lindskogen
reviewed
Oct 2, 2023
lindskogen
reviewed
Oct 2, 2023
lindskogen
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments and questions 😊
…esign. Normal and loading still has border. - Update colors of TextInput variants. - NavBarHeading is now h1 level (but still has h4 design). - PageHeading has default h2 level, but can still be changed.
…nt-sizes without the design breaking.
This was referenced Oct 3, 2023
mattias800
added a commit
that referenced
this pull request
Oct 5, 2023
This was referenced Oct 10, 2023
Merged
Merged
This was referenced Oct 17, 2023
This was referenced Nov 3, 2023
This was referenced Nov 10, 2023
Merged
This was referenced Nov 22, 2023
Merged
Merged
Merged
This was referenced Dec 1, 2023
This was referenced Dec 8, 2023
This was referenced Dec 15, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fortawesome/fontawesome-svg-core
instead of the icon library packages.PageHeader
TextInput
Version
Published prerelease version:
v19.0.0-next.6
Changelog
💥 Breaking Change
@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/panels
🐛 Bug Fix
@stenajs-webui/calendar
,@stenajs-webui/elements
,@stenajs-webui/filter
,@stenajs-webui/forms
,@stenajs-webui/grid-export
,@stenajs-webui/grid
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/elements
@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/filter
,@stenajs-webui/modal
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/theme
@stenajs-webui/filter
@stenajs-webui/elements
,@stenajs-webui/panels
,@stenajs-webui/theme
,@stenajs-webui/tooltip
@stenajs-webui/elements
,@stenajs-webui/modal
,@stenajs-webui/panels
@stenajs-webui/elements
,@stenajs-webui/theme
Authors: 4