Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating SearchFilterDrawer #616

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

mattias800
Copy link
Collaborator

@mattias800 mattias800 commented Oct 10, 2023

  • Add floating prop to Drawer. It creates a gap between Drawer and viewport, and adds round corners.
  • SearchFilterDrawer is now floating.
  • Header of SearchFilterDrawer is now sticky.
  • Update SearchFilter stories, chips and button are now in a Box, not in a Card.

image

image

Version

Published prerelease version: v19.0.0-next.13

Changelog

💥 Breaking Change

  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/panels

🐛 Bug Fix

  • Add prerelease step for next branch #602 (@lindskogen)
  • @stenajs-webui/filter, @stenajs-webui/modal
  • @stenajs-webui/panels
  • @stenajs-webui/elements, @stenajs-webui/theme
  • @stenajs-webui/elements, @stenajs-webui/grid-export, @stenajs-webui/panels
  • @stenajs-webui/forms, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/forms, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/elements
  • @stenajs-webui/calendar, @stenajs-webui/elements, @stenajs-webui/filter, @stenajs-webui/forms, @stenajs-webui/grid-export, @stenajs-webui/grid, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/filter, @stenajs-webui/modal, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/theme
  • @stenajs-webui/filter
  • @stenajs-webui/elements, @stenajs-webui/panels, @stenajs-webui/theme, @stenajs-webui/tooltip
  • @stenajs-webui/elements, @stenajs-webui/modal, @stenajs-webui/panels

⚠️ Pushed to next

Authors: 4

…viewport, and adds round corners.

- SearchFilterDrawer is now floating.
- Header of SearchFilterDrawer is now sticky.
@github-actions
Copy link

Size Change: 0 B

Total Size: 352 kB

ℹ️ View Unchanged
Filename Size
packages/calendar/dist/index.es.js 15 kB
packages/calendar/dist/index.js 12.9 kB
packages/core/dist/index.es.js 4.97 kB
packages/core/dist/index.js 4.65 kB
packages/elements/dist/index.es.js 108 kB
packages/elements/dist/index.js 107 kB
packages/filter/dist/index.es.js 3.85 kB
packages/filter/dist/index.js 3.34 kB
packages/forms/dist/index.es.js 6.75 kB
packages/forms/dist/index.js 6.25 kB
packages/grid-export/dist/index.es.js 2.04 kB
packages/grid-export/dist/index.js 1.99 kB
packages/grid/dist/index.es.js 16 kB
packages/grid/dist/index.js 13.8 kB
packages/input-mask/dist/index.es.js 804 B
packages/input-mask/dist/index.js 735 B
packages/modal/dist/index.es.js 3.1 kB
packages/modal/dist/index.js 2.92 kB
packages/panels/dist/index.es.js 8.07 kB
packages/panels/dist/index.js 7.36 kB
packages/redux/dist/index.es.js 3.06 kB
packages/redux/dist/index.js 2.75 kB
packages/select/dist/index.es.js 4.02 kB
packages/select/dist/index.js 3.65 kB
packages/theme/dist/index.es.js 1.99 kB
packages/theme/dist/index.js 2.05 kB
packages/tooltip/dist/index.es.js 2.91 kB
packages/tooltip/dist/index.js 2.72 kB

compressed-size-action

@lindskogen lindskogen merged commit 7250c23 into next Oct 11, 2023
6 checks passed
@lindskogen lindskogen deleted the feature/redesign-floating-filter-drawer branch October 11, 2023 17:29
lindskogen pushed a commit that referenced this pull request Oct 17, 2023
- Add `floating` prop to Drawer. It creates a gap between Drawer and viewport, and adds round corners.
- SearchFilterDrawer is now floating.
- Header of SearchFilterDrawer is now sticky.
lindskogen added a commit that referenced this pull request Oct 17, 2023
* -

* Spread all props into RailMenuLink (#618)

Needed to allow custom `renderLink` function in rail mode.

* Bump lerna to 7 (#614)

* Bump lerna and remove deprecated link command

* Update github action run script

* Bump compressed-size-action to not use node 12

* Use full commit SHA for compressed-size-action

* Bump storybook and related dependencies (#581)

Co-authored-by: Mattias Andersson <[email protected]>

* Floating SearchFilterDrawer (#616)

- Add `floating` prop to Drawer. It creates a gap between Drawer and viewport, and adds round corners.
- SearchFilterDrawer is now floating.
- Header of SearchFilterDrawer is now sticky.

* Make sidebarmenu close button sticky

---------

Co-authored-by: Johan Lindskogen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants