-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile improvements in Drawer #623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 352 kB ℹ️ View Unchanged
|
mattias800
approved these changes
Oct 13, 2023
This was referenced Oct 16, 2023
Merged
Merged
This was referenced Oct 23, 2023
Merged
Merged
Merged
Merged
This was referenced Oct 30, 2023
Merged
This was referenced Nov 3, 2023
This was referenced Nov 10, 2023
Merged
This was referenced Nov 22, 2023
Merged
Merged
Merged
This was referenced Dec 1, 2023
This was referenced Dec 8, 2023
This was referenced Dec 15, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
100dvh
instead of100vh
fixes the following scroll issue on mobile:Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-10-13.at.15.56.04.mp4
This PR also removes margin and border-radius for Drawer.
Version
Published prerelease version:
v19.0.0-next.18
Changelog
💥 Breaking Change
@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/panels
🐛 Bug Fix
@stenajs-webui/modal
,@stenajs-webui/panels
@stenajs-webui/forms
@stenajs-webui/grid
@stenajs-webui/elements
,@stenajs-webui/filter
,@stenajs-webui/modal
,@stenajs-webui/panels
@stenajs-webui/elements
,@stenajs-webui/panels
@stenajs-webui/filter
,@stenajs-webui/modal
@stenajs-webui/panels
@stenajs-webui/elements
,@stenajs-webui/theme
@stenajs-webui/elements
,@stenajs-webui/grid-export
,@stenajs-webui/panels
@stenajs-webui/forms
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/forms
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/elements
@stenajs-webui/calendar
,@stenajs-webui/elements
,@stenajs-webui/filter
,@stenajs-webui/forms
,@stenajs-webui/grid-export
,@stenajs-webui/grid
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/filter
,@stenajs-webui/modal
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/theme
@stenajs-webui/filter
@stenajs-webui/elements
,@stenajs-webui/panels
,@stenajs-webui/theme
,@stenajs-webui/tooltip
@stenajs-webui/elements
,@stenajs-webui/modal
,@stenajs-webui/panels
next
Authors: 4