Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile improvements in Drawer #623

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Conversation

lindskogen
Copy link
Collaborator

@lindskogen lindskogen commented Oct 13, 2023

Using 100dvh instead of 100vh fixes the following scroll issue on mobile:

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2023-10-13.at.15.56.04.mp4

This PR also removes margin and border-radius for Drawer.

Version

Published prerelease version: v19.0.0-next.18

Changelog

💥 Breaking Change

  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/panels

🐛 Bug Fix

  • Add prerelease step for next branch #602 (@lindskogen)
  • @stenajs-webui/modal, @stenajs-webui/panels
  • @stenajs-webui/forms
  • @stenajs-webui/grid
  • @stenajs-webui/elements, @stenajs-webui/filter, @stenajs-webui/modal, @stenajs-webui/panels
  • @stenajs-webui/elements, @stenajs-webui/panels
  • @stenajs-webui/filter, @stenajs-webui/modal
  • @stenajs-webui/panels
  • @stenajs-webui/elements, @stenajs-webui/theme
  • @stenajs-webui/elements, @stenajs-webui/grid-export, @stenajs-webui/panels
  • @stenajs-webui/forms, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/forms, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/elements
  • @stenajs-webui/calendar, @stenajs-webui/elements, @stenajs-webui/filter, @stenajs-webui/forms, @stenajs-webui/grid-export, @stenajs-webui/grid, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/filter, @stenajs-webui/modal, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/theme
  • @stenajs-webui/filter
  • @stenajs-webui/elements, @stenajs-webui/panels, @stenajs-webui/theme, @stenajs-webui/tooltip
  • @stenajs-webui/elements, @stenajs-webui/modal, @stenajs-webui/panels

⚠️ Pushed to next

Authors: 4

@lindskogen lindskogen requested a review from a team October 13, 2023 14:09
@github-actions
Copy link

Size Change: 0 B

Total Size: 352 kB

ℹ️ View Unchanged
Filename Size
packages/calendar/dist/index.es.js 15.2 kB
packages/calendar/dist/index.js 12.9 kB
packages/core/dist/index.es.js 5.03 kB
packages/core/dist/index.js 4.65 kB
packages/elements/dist/index.es.js 109 kB
packages/elements/dist/index.js 107 kB
packages/filter/dist/index.es.js 3.79 kB
packages/filter/dist/index.js 3.21 kB
packages/forms/dist/index.es.js 6.85 kB
packages/forms/dist/index.js 6.24 kB
packages/grid-export/dist/index.es.js 2.05 kB
packages/grid-export/dist/index.js 1.99 kB
packages/grid/dist/index.es.js 16.7 kB
packages/grid/dist/index.js 13.9 kB
packages/input-mask/dist/index.es.js 814 B
packages/input-mask/dist/index.js 734 B
packages/modal/dist/index.es.js 3.42 kB
packages/modal/dist/index.js 3.09 kB
packages/panels/dist/index.es.js 7.02 kB
packages/panels/dist/index.js 6.21 kB
packages/redux/dist/index.es.js 3.06 kB
packages/redux/dist/index.js 2.75 kB
packages/select/dist/index.es.js 4.08 kB
packages/select/dist/index.js 3.65 kB
packages/theme/dist/index.es.js 1.99 kB
packages/theme/dist/index.js 2.05 kB
packages/tooltip/dist/index.es.js 2.92 kB
packages/tooltip/dist/index.js 2.72 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants