-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon sizes and CircledIcon xl size #656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There are two sizes for now, medium and xl. - SVG:s ending with "xl" will be size xl. Everything else is medium. - Components can now use types `MediumIcon` and `XlIcon` to require the correct icon size. - CircledIcon is the first to use this, for its new size=xl. - Components that use CircledIcon now requires `icon: MediumIcon` instead of `IconDefinition`. - Add new lighthouse-xl icon.
mattias800
requested review from
lindskogen,
nikteg,
esepato and
AugustasFriend
November 2, 2023 16:17
Size Change: 0 B Total Size: 318 kB ℹ️ View Unchanged
|
lindskogen
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
This was referenced Nov 3, 2023
This was referenced Nov 10, 2023
Merged
This was referenced Nov 22, 2023
Merged
Merged
This was referenced Nov 27, 2023
Merged
This was referenced Dec 7, 2023
This was referenced Dec 15, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
medium
andxl
.MediumIcon
andXlIcon
to require the correct icon size.xl
.icon: MediumIcon
instead ofIconDefinition
.Version
Published prerelease version:
v19.0.0-next.47
Changelog
💥 Breaking Change
@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/panels
🐛 Bug Fix
@stenajs-webui/elements
,@stenajs-webui/panels
@stenajs-webui/elements
@stenajs-webui/forms
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/panels
,@stenajs-webui/tooltip
@stenajs-webui/calendar
,@stenajs-webui/forms
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/modal
,@stenajs-webui/select
,@stenajs-webui/theme
@stenajs-webui/forms
,@stenajs-webui/theme
@stenajs-webui/elements
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/forms
,@stenajs-webui/theme
@stenajs-webui/elements
,@stenajs-webui/filter
@stenajs-webui/elements
,@stenajs-webui/forms
,@stenajs-webui/select
,@stenajs-webui/theme
@stenajs-webui/elements
,@stenajs-webui/forms
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/filter
,@stenajs-webui/forms
,@stenajs-webui/theme
@stenajs-webui/core
,@stenajs-webui/panels
@stenajs-webui/panels
@stenajs-webui/modal
,@stenajs-webui/panels
@stenajs-webui/forms
@stenajs-webui/grid
@stenajs-webui/elements
,@stenajs-webui/filter
,@stenajs-webui/modal
,@stenajs-webui/panels
@stenajs-webui/filter
,@stenajs-webui/modal
@stenajs-webui/elements
,@stenajs-webui/theme
@stenajs-webui/elements
,@stenajs-webui/grid-export
,@stenajs-webui/panels
@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/forms
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/calendar
,@stenajs-webui/elements
,@stenajs-webui/filter
,@stenajs-webui/forms
,@stenajs-webui/grid-export
,@stenajs-webui/grid
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/filter
,@stenajs-webui/modal
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/panels
,@stenajs-webui/theme
@stenajs-webui/theme
@stenajs-webui/filter
@stenajs-webui/elements
,@stenajs-webui/panels
,@stenajs-webui/theme
,@stenajs-webui/tooltip
@stenajs-webui/elements
,@stenajs-webui/modal
,@stenajs-webui/panels
next
@stenajs-webui/calendar
,@stenajs-webui/core
,@stenajs-webui/elements
,@stenajs-webui/filter
,@stenajs-webui/forms
,@stenajs-webui/grid-export
,@stenajs-webui/grid
,@stenajs-webui/input-mask
,@stenajs-webui/modal
,@stenajs-webui/panels
,@stenajs-webui/redux
,@stenajs-webui/select
,@stenajs-webui/theme
,@stenajs-webui/tooltip
Authors: 4