Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon sizes and CircledIcon xl size #656

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Conversation

mattias800
Copy link
Collaborator

@mattias800 mattias800 commented Nov 2, 2023

  • Introduce the concept of icon sizes.
  • There are two sizes for now, medium and xl.
  • SVG:s ending with "xl" will be size xl. Everything else is medium.
  • Components can now use types MediumIcon and XlIcon to require the correct icon size.
  • CircledIcon is the first to use this, for its new size variant xl.
  • Components that use CircledIcon have been updated with prop icon: MediumIcon instead of IconDefinition.
  • Add new lighthouse-xl icon.

image

Version

Published prerelease version: v19.0.0-next.47

Changelog

💥 Breaking Change

  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/panels

🐛 Bug Fix

  • Add prerelease step for next branch #602 (@lindskogen)
  • @stenajs-webui/elements, @stenajs-webui/panels
  • @stenajs-webui/elements
  • @stenajs-webui/forms, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/panels, @stenajs-webui/tooltip
  • @stenajs-webui/calendar, @stenajs-webui/forms, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/modal, @stenajs-webui/select, @stenajs-webui/theme
  • @stenajs-webui/forms, @stenajs-webui/theme
  • @stenajs-webui/elements, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/forms, @stenajs-webui/theme
  • @stenajs-webui/elements, @stenajs-webui/filter
  • @stenajs-webui/elements, @stenajs-webui/forms, @stenajs-webui/select, @stenajs-webui/theme
  • @stenajs-webui/elements, @stenajs-webui/forms, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/filter, @stenajs-webui/forms, @stenajs-webui/theme
  • @stenajs-webui/core, @stenajs-webui/panels
  • @stenajs-webui/panels
  • @stenajs-webui/modal, @stenajs-webui/panels
  • @stenajs-webui/forms
  • @stenajs-webui/grid
  • @stenajs-webui/elements, @stenajs-webui/filter, @stenajs-webui/modal, @stenajs-webui/panels
  • @stenajs-webui/filter, @stenajs-webui/modal
  • @stenajs-webui/elements, @stenajs-webui/theme
  • @stenajs-webui/elements, @stenajs-webui/grid-export, @stenajs-webui/panels
  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/forms, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/calendar, @stenajs-webui/elements, @stenajs-webui/filter, @stenajs-webui/forms, @stenajs-webui/grid-export, @stenajs-webui/grid, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/filter, @stenajs-webui/modal, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/panels, @stenajs-webui/theme
  • @stenajs-webui/theme
  • @stenajs-webui/filter
  • @stenajs-webui/elements, @stenajs-webui/panels, @stenajs-webui/theme, @stenajs-webui/tooltip
  • @stenajs-webui/elements, @stenajs-webui/modal, @stenajs-webui/panels

⚠️ Pushed to next

  • Merge branch 'master' into next (@lindskogen)
  • @stenajs-webui/calendar, @stenajs-webui/core, @stenajs-webui/elements, @stenajs-webui/filter, @stenajs-webui/forms, @stenajs-webui/grid-export, @stenajs-webui/grid, @stenajs-webui/input-mask, @stenajs-webui/modal, @stenajs-webui/panels, @stenajs-webui/redux, @stenajs-webui/select, @stenajs-webui/theme, @stenajs-webui/tooltip
    • Merge remote-tracking branch 'origin/master' into next (@mattias800)

Authors: 4

- There are two sizes for now, medium and xl.
- SVG:s ending with "xl" will be size xl. Everything else is medium.
- Components can now use types `MediumIcon` and `XlIcon` to require the correct icon size.
- CircledIcon is the first to use this, for its new size=xl.
- Components that use CircledIcon now requires `icon: MediumIcon` instead of `IconDefinition`.
- Add new lighthouse-xl icon.
Copy link

github-actions bot commented Nov 2, 2023

Size Change: 0 B

Total Size: 318 kB

ℹ️ View Unchanged
Filename Size
packages/calendar/dist/index.es.js 15.3 kB
packages/calendar/dist/index.js 12.9 kB
packages/core/dist/index.es.js 5.2 kB
packages/core/dist/index.js 4.81 kB
packages/elements/dist/index.es.js 90.1 kB
packages/elements/dist/index.js 87.9 kB
packages/filter/dist/index.es.js 3.87 kB
packages/filter/dist/index.js 3.27 kB
packages/forms/dist/index.es.js 8.15 kB
packages/forms/dist/index.js 7.49 kB
packages/grid-export/dist/index.es.js 2.05 kB
packages/grid-export/dist/index.js 1.99 kB
packages/grid/dist/index.es.js 16.7 kB
packages/grid/dist/index.js 13.9 kB
packages/input-mask/dist/index.es.js 814 B
packages/input-mask/dist/index.js 734 B
packages/modal/dist/index.es.js 3.42 kB
packages/modal/dist/index.js 3.09 kB
packages/panels/dist/index.es.js 7.24 kB
packages/panels/dist/index.js 6.37 kB
packages/redux/dist/index.es.js 3.06 kB
packages/redux/dist/index.js 2.75 kB
packages/select/dist/index.es.js 4.12 kB
packages/select/dist/index.js 3.69 kB
packages/theme/dist/index.es.js 1.96 kB
packages/theme/dist/index.js 2.02 kB
packages/tooltip/dist/index.es.js 2.92 kB
packages/tooltip/dist/index.js 2.72 kB

compressed-size-action

Copy link
Collaborator

@lindskogen lindskogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants