Update StandardTable to allow easy ways to reduce text size #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### defaultCellRenderer This can be used to override default text renderer for the whole table. Column cellRenderer will still override this. Since this is global for the table, and not local to a column, the type of itemValue can not be known. It should use `label` as source of text instead. If omitted, TextCell is used as usual. ### defaultTextSize This config specifies the text size to be used by the default TextCell component. If omitted, "normal" is used.
mattias800
requested review from
lindskogen,
nikteg,
esepato and
AugustasFriend
|
Size Change: 0 B Total Size: 352 kB ℹ️ View Unchanged
|
esepato
reviewed
Oct 13, 2023
| }) { | ||
| return ( | ||
| <Indent overflow={"hidden"}> | ||
| <Text className={styles.textCell} title={label}> | ||
| <Text className={styles.textCell} title={label} size={size} color={color}> |
There was a problem hiding this comment.
I believe that a similar thing is needed for renderCell/createStandardEditableTextCell as the default text size is not applied there
There was a problem hiding this comment.
Or wait. It is always supposed to be custom content on how to display the editable cell?
There was a problem hiding this comment.
renderCell already has full control over how to render the cell.
But yes, createStandardEditableTextCell should allow textSize as well.
I have added a commit.
esepato
approved these changes
Oct 13, 2023
lindskogen
approved these changes
Oct 13, 2023
This was referenced Oct 13, 2023
Merged
Merged
This was referenced Oct 23, 2023
Merged
This was referenced Nov 3, 2023
This was referenced Nov 10, 2023
Merged
This was referenced Nov 22, 2023
Merged
Merged
Merged
This was referenced Dec 1, 2023
This was referenced Dec 8, 2023
This was referenced Dec 15, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultCellRenderer
This can be used to override default text renderer for the whole table.
Column cellRenderer will still override this. Since this is global for the table, and not local to a column,
the type of itemValue can not be known. It should use
labelas source of text instead.If omitted, TextCell is used as usual.
defaultTextSize
This config specifies the text size to be used by the default TextCell component.
If omitted, "normal" is used.
Version
Published prerelease version:
v19.0.0-next.16Changelog
💥 Breaking Change
@stenajs-webui/core,@stenajs-webui/elements,@stenajs-webui/panels🐛 Bug Fix
@stenajs-webui/grid@stenajs-webui/elements,@stenajs-webui/filter,@stenajs-webui/modal,@stenajs-webui/panels@stenajs-webui/elements,@stenajs-webui/panels@stenajs-webui/filter,@stenajs-webui/modal@stenajs-webui/panels@stenajs-webui/elements,@stenajs-webui/theme@stenajs-webui/elements,@stenajs-webui/grid-export,@stenajs-webui/panels@stenajs-webui/forms,@stenajs-webui/panels,@stenajs-webui/theme@stenajs-webui/core,@stenajs-webui/elements,@stenajs-webui/forms,@stenajs-webui/panels,@stenajs-webui/theme@stenajs-webui/elements@stenajs-webui/calendar,@stenajs-webui/elements,@stenajs-webui/filter,@stenajs-webui/forms,@stenajs-webui/grid-export,@stenajs-webui/grid,@stenajs-webui/panels,@stenajs-webui/theme@stenajs-webui/core,@stenajs-webui/elements,@stenajs-webui/filter,@stenajs-webui/modal,@stenajs-webui/panels,@stenajs-webui/theme@stenajs-webui/core,@stenajs-webui/elements,@stenajs-webui/panels,@stenajs-webui/theme@stenajs-webui/theme@stenajs-webui/filter@stenajs-webui/elements,@stenajs-webui/panels,@stenajs-webui/theme,@stenajs-webui/tooltip@stenajs-webui/elements,@stenajs-webui/modal,@stenajs-webui/panelsnextAuthors: 4