Redesign notifications #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SearchFilterPanelHeader now uses DrawerHeader. - NotificationHeader now uses DrawerHeader. - Add NotificationList component, which should wrap notifications. - Increase height of tab menu to 40px. - Update design of notifications, including a large demo story as designed by Chris. - Update CircledIcon stories to use Stena icons (except for spinner). - Remove iconSize prop from CircledIcon. Can now only use predefined size variants, which sets both background and icon size.
mattias800
requested review from
AugustasFriend,
lindskogen,
nikteg and
esepato
|
Size Change: 0 B Total Size: 352 kB ℹ️ View Unchanged
|
lindskogen
reviewed
Oct 11, 2023
Comment on lines
+48
to
+57
| const getIconSize = (size: CircledIconSizeVariant): number => { | ||
| switch (size) { | ||
| case "small": | ||
| return 16; | ||
| case "medium": | ||
| return 20; | ||
| default: | ||
| return exhaustSwitchCaseElseThrow(size); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Why is background size a string, when this is a number? Use number everywhere!
There was a problem hiding this comment.
I'd argue the opposite.
Icon takes number and then converts it to rem (40 becomes 4.0rem).
Box can take a number, but just adds "px" suffix (40 becomes 40px).
Unit should be explicit so that it is clear where the UI should scale with accessible font size, and where it should not.
Regardless, that is not within the scope of notifications :)
One could argue that the icon should not scale with accessible font size, but that would affect many many components. I'll take it up with Chris and Anton.
lindskogen
approved these changes
Oct 12, 2023
…ys-stuff # Conflicts: # packages/filter/src/features/search-filter/components/SearchFilterPanelHeader.tsx
This was referenced Oct 13, 2023
Merged
Merged
This was referenced Oct 23, 2023
This was referenced Nov 3, 2023
This was referenced Nov 10, 2023
Merged
This was referenced Nov 22, 2023
Merged
Merged
Merged
This was referenced Dec 1, 2023
This was referenced Dec 8, 2023
This was referenced Dec 15, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
Published prerelease version:
v19.0.0-next.15Changelog
💥 Breaking Change
@stenajs-webui/core,@stenajs-webui/elements,@stenajs-webui/panels🐛 Bug Fix
@stenajs-webui/elements,@stenajs-webui/filter,@stenajs-webui/modal,@stenajs-webui/panels@stenajs-webui/elements,@stenajs-webui/panels@stenajs-webui/filter,@stenajs-webui/modal@stenajs-webui/panels@stenajs-webui/elements,@stenajs-webui/theme@stenajs-webui/elements,@stenajs-webui/grid-export,@stenajs-webui/panels@stenajs-webui/forms,@stenajs-webui/panels,@stenajs-webui/theme@stenajs-webui/core,@stenajs-webui/elements,@stenajs-webui/forms,@stenajs-webui/panels,@stenajs-webui/theme@stenajs-webui/elements@stenajs-webui/calendar,@stenajs-webui/elements,@stenajs-webui/filter,@stenajs-webui/forms,@stenajs-webui/grid-export,@stenajs-webui/grid,@stenajs-webui/panels,@stenajs-webui/theme@stenajs-webui/core,@stenajs-webui/elements,@stenajs-webui/filter,@stenajs-webui/modal,@stenajs-webui/panels,@stenajs-webui/theme@stenajs-webui/core,@stenajs-webui/elements,@stenajs-webui/panels,@stenajs-webui/theme@stenajs-webui/theme@stenajs-webui/filter@stenajs-webui/elements,@stenajs-webui/panels,@stenajs-webui/theme,@stenajs-webui/tooltip@stenajs-webui/elements,@stenajs-webui/modal,@stenajs-webui/panelsnextAuthors: 4