Changes to the UI library #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update the API class to use the updated API behavior with userActions 2. Update the User Actions concepts so that the action menu now looks for QUICK_ACTIONS, which would be a new subType of User Actions (see integration-base for implementation details there). This also removes any pre-baked user actions from the dropdown. 3. Update the form population to allow for initialData where appropriate 4. Update the form handling to make sure keystrokes are added to the formData so that it properly submits 5. Update the UserActionModal to handle a bit more streamlined 6. Update the IntegrationHorizontal componet and List to keep the heights at a max TODO: [] Iterate over time. These components will need to be considered for their flexibility and configurability so that an adopter doesn't feel compelled to ditch the frigg-built/managed components in favor of rolling their own. [] Make a cleaner distinction what is "throwaway, demonstration UI" and what is our true UI library.
This was referenced Oct 17, 2024
Open
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
seanspeaks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Action API and UI Component Updates
Update the API class to use the updated API behavior with userActions
getUserActionOptionsmethod to use POST instead of GETgetUserActionsmethodUpdate the User Actions concepts
IntegrationHorizontalto fetch QUICK_ACTIONS from the APIUpdate the form population to allow for initialData
UserActionModalto accept and useinitialDatapropUpdate the form handling for proper submission
UserActionModalStreamline the UserActionModal
Update IntegrationHorizontal and List components
Additional changes:
UserActionModalto exports inindex.jsTODO: