Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frigg start command #349

Open
wants to merge 3 commits into
base: license-update
Choose a base branch
from

Conversation

seanspeaks
Copy link
Contributor

@seanspeaks seanspeaks commented Oct 17, 2024

Update the CLI to include the new frigg start command.
Update tests, basic for now.
Migrate the backend-js and commit-changes helper functions over.

TODO:

  • Likely need to make sure we've updated so that we're looking for either index or backend.js
  • Likely need to be js or ts agnostic
  • Likely need to assert that the output of the backend or index.js files/modules are properly formatted/confirm that they're what we want.
  • Not sure how this works with ts.

Remove old CLI files for restructure and some removal

Added helper functions and migrated from prior setup (basically, lots of renaming) for frigg-cli directory structure.

The changes include:

  • Adding a new start command to the CLI
  • Updating the main index.js file to include the new command
  • Creating a new start-command directory with an index.js file for the start command implementation
  • Restructuring the existing install command files into an install-command directory
  • Updating import paths and file names to reflect the new structure
  • Migrating helper functions and renaming them for consistency
  • Updating tests to work with the new structure
  • Removing the old environmentVariables.test.js file and replacing it with a new one in the install-command directory

Update tests, basic for now.
Migrate the backend-js and commit-changes helper functions over.
TODO:
[] Likely need to make sure we've updated so that we're looking for either index or backend.js
[] Likely need to be js or ts agnostic
[] Likely need to assert that the output of the backend or index.js files/modules are properly formatted/confirm that they're what we want.
[] Not sure how this works with ts.
… of renaming) for frigg-cli directory structure.
1 similar comment
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@seanspeaks seanspeaks mentioned this pull request Oct 17, 2024
2 tasks
@seanspeaks seanspeaks marked this pull request as ready for review October 17, 2024 03:36
@seanspeaks seanspeaks changed the title Update the CLI to include the new frigg start command. Update tests, basic for now. Migrate the backend-js and commit-changes helper functions over. TODO: [] Likely need to make sure we've updated so that we're looking for either index or backend.js [] Likely need to be js or ts agnostic [] Likely need to assert that the output of the backend or index.js files/modules are properly formatted/confirm that they're what we want. [] Not sure how this works with ts. Add frigg start command Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant