Update Integration Base class to v2 #344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d a different name? Basically, this loads up the class with helper methods and functions that are used by the rest of Frigg core to be able to take advantage of new updates and concepts in Frigg v2. - Removes the legacy "notify" concept with the "delegate" pattern. - Replaces with "send", which is similar in concept to a state machine send that XState uses. But ultimately it's sending an event to the integration instance, with data, which ultimately invokes the handler found at the "on" event register. - Adds an event handler registration method and flow, whereby standard/default/lifecycle events are added to the register - Adds user action concepts/loaders - Adds a few other helper functions intended to be used in various implementation moments across the framework - Centralizes the "Definition" concept so that there's a static definition and a dynamic constructor-based loading of instance variables and event handlers All of these should likely be combined with another few commits. And tested with the v1.3 prototyping repo.
This was referenced Oct 17, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 17, 2024
Open
|
This was referenced Oct 17, 2024
seanspeaks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration Base Class Overhaul
This update significantly revamps the Integration Base class, introducing new concepts and methods to align with Frigg v2 architecture:
Key changes include:
loadModules()method to dynamically load modules defined inDefinition.modules.registerEventHandlers()method to set up default and custom event handlers.send()method for triggering events with associated data.testAuth()method to handle multiple modules.loadDynamicUserActions()andloadUserActions().getActionOptions()method signature.This update lays the groundwork for the new integration structure in Frigg v2. Further testing and potential refinements may be necessary when integrated with the v1.3 prototyping repository.