Add the new Frigg Serverless Plugin #352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igrate off serverless?) that creates the queues in the localstack SQS instead of requiring the user to run a bash script/command. Also sets the stage to do a lot more, now that I/we know how to write plugins (pretty easy actually). TODO: [] Webpack fix? [] Start localstack? Check to see if it's running? [] Allow a flag to determine what to run (THIS ONE IS CRITICAL FOR WORKING WITH PROD)
This was referenced Oct 17, 2024
Open
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| }); | ||
|
|
||
| const sqs = new AWS.SQS(); | ||
| // Find the environment variables that we nee dto override and create an easy map |
There was a problem hiding this comment.
The comment contains a typo. Please correct 'nee dto' to 'need to' for improved readability:
Suggested change
| // Find the environment variables that we nee dto override and create an easy map | |
| // Find the environment variables that we need to override and create an easy map |
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
seanspeaks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new Frigg Serverless Plugin (which, may be obsolete once we migrate off serverless?) that creates the queues in the localstack SQS instead of requiring the user to run a bash script/command.
This plugin initializes during the serverless offline command, creating SQS queues in localstack based on the custom configuration. It also updates the environment variables with the newly created queue URLs.
Also sets the stage to do a lot more, now that I/we know how to write plugins (pretty easy actually).
TODO:
[] Webpack fix?
[] Start localstack? Check to see if it's running?
[] Allow a flag to determine what to run (THIS ONE IS CRITICAL FOR WORKING WITH PROD)