Update integration-router to use the new .send method and default lifecycle events. #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecycle events. Update the "options" ... mixin? class? to read from the updated integration and module Definition fields properly. Formatting automatically applied via prettier/eslint fix, so just leaving it in there, but that's it for the auther.js file.
This was referenced Oct 17, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 17, 2024
Open
|
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the "options" class to read from the updated integration and module Definition fields properly.
The main changes include:
this.display.nameto read fromparams.display.labelinstead ofparams.display.namethis.module.getName()tothis.module.definition.getName()Formatting automatically applied via prettier/eslint fix for the integration-router.js and auther.js files.
The integration-router.js file has been updated to use the new
sendmethod for various integration actions, replacing direct method calls likeonCreate,onUpdate,onDelete, etc.