Radians to Degrees for multi-tag pose #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
reviewed
Nov 26, 2023
| <td> | ||
| {{ | ||
| ( | ||
| useStateStore().currentPipelineResults?.multitagResult?.bestTransform.angle_z * |
There was a problem hiding this comment.
If this angle ends up being undefined, what's the output of the rest of this function? Should we just do angle_z || 0?
There was a problem hiding this comment.
In what situation would multitagResult be valid but bestTransform.angle_z undefined?
There was a problem hiding this comment.
Should be never, actually? I'm actually not super familiar with how ?. works in JavaScript so I may need enlightning
There was a problem hiding this comment.
I built this code and saw no issues with multi pnp but I can add the || 0 if you prefer
There was a problem hiding this comment.
Go ahead and add that to all multitarget props as all of them may be undefined
srimanachanta
force-pushed
the
patch-1
branch
from
1ee4dde
to
14b85d6
Compare
srimanachanta
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1025