-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Mount: support gimbal_manager_status and do_gimbal_manager_configure #23737
AP_Mount: support gimbal_manager_status and do_gimbal_manager_configure #23737
Conversation
Co-authored-by: Randy Mackay <[email protected]>
…igure Co-authored-by: Randy Mackay <[email protected]>
mavlink msg required to extra caller's sysid/compid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for the blimp changes - sorry, I really need to do a lot of removal of unused code there...
Looking great, thank you! |
Hello all, Was this PR intended to allow DO_GIMBAL_MANAGER_CONFIGURE to work as a mission item, sent inside a mission sequence?. I do not see DO_GIMBAL_MANAGER_CONFIGURE as a supported command in https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_Mission/AP_Mission.cpp. |
This supersedes PR #23713
This adds superficial support for two new mavlink messages meant to help de-conflict multiple mavlink devices attempting to control a gimbal. This is important so that development of QGC's camera/gimbal control screen can progress.
The support is "superficial" because it does not actually reject gimbal control commands that comes from devices that are not in control. To comprehensively block commands we need to consolidate handling of more commands (including DO_SET_ROI) within the AP_Mount library instead of within GCS_MAVLink.
This has been lightly tested in SITL including:
There's also a drive-by bug fix to the GIMBAL_MANAGER_INFORMATION gimbal_device_id instance field.