Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/Common: camera and gimbal updates #5307

Merged
merged 6 commits into from
Aug 2, 2023

Conversation

rmackay9
Copy link
Contributor

This PR includes camera and gimbal related updates for both the developer and user wikis.

The developer wiki gets details on new commands supported in AP-4.5.0

The user wiki gets warnings and fixes for the Siyi and Gremsy gimbals.

This has been tested locally and seems OK.

@rmackay9
Copy link
Contributor Author

I'd accidentally committed some changes to the build options file which I've removed now. Sorry about that.

@Hwurzburg
Copy link
Contributor

Added link in upcoming features

@rmackay9
Copy link
Contributor Author

Hi @Hwurzburg,

Thanks for that. I think we should consider merging this before 4.5 is ready because many developers work off of master. Also the non-dev changes are valid for 4.4.

@Hwurzburg
Copy link
Contributor

Hwurzburg commented Aug 1, 2023

the non dev changes state 4.5 or higher....not 4.4....a mistake? if not, we can split them out as 4.5 and merge the dev only stuff...I am okay with that

also does this cover the changes you made in #23737?

@rmackay9
Copy link
Contributor Author

rmackay9 commented Aug 2, 2023

Hi @Hwurzburg,

I've removed the Gremsy 4.5.0 related change and will put that in a separate PR. I think the rest of the changes are development (which can go in even though the stable version is not 4.5 yet) or are user wiki changes not related to 4.5.

I'm afraid these changes do not cover the changes made in PR ArduPilot/ardupilot#23737

@Hwurzburg
Copy link
Contributor

Thanks...merging

@Hwurzburg Hwurzburg merged commit c601d8c into ArduPilot:master Aug 2, 2023
@rmackay9 rmackay9 deleted the dev-gimbal-info branch August 3, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants