Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export users and credential to csv #2961

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Dec 17, 2024

This PR resolves #2956

Changes:

  • Added the ability to extract User List and Credential List to CSV.
  • Since many interaction buttons already exist in the Card Content, I use the Card Tab Extra field and provide them via Event Listen.

How to test:

  • In the User List or Credential List, run the CSV extract via the buttons in the Card Tab Extra section
  • Verify that each column is displayed correctly.

Discussions:
Currently, CSV exports are executed based on the data fetched via the request, not the information shown in the table. So, if the key is not the same as the Key of the response data type, or is shown separately in the render function without using response data, you cannot extract that data.

The CSV export function will be changed in the future. We plan to define CSV columns in the same way as Antd's table column definitions to support column ordering and customization of CSV data. This will be a separate issue and stack.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author

ironAiken2 commented Dec 17, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ironAiken2 ironAiken2 linked an issue Dec 17, 2024 that may be closed by this pull request
@ironAiken2 ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from aa394c7 to b70cc28 Compare December 17, 2024 04:54
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch from 7aa08f5 to 0d7d98d Compare December 17, 2024 05:20
@github-actions github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Dec 17, 2024
@ironAiken2 ironAiken2 marked this pull request as ready for review December 17, 2024 05:30
@ironAiken2 ironAiken2 marked this pull request as draft December 17, 2024 07:29
@ironAiken2 ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from b70cc28 to 81fec82 Compare December 17, 2024 07:34
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch 2 times, most recently from 9e72899 to 0460eca Compare December 17, 2024 08:04
@ironAiken2 ironAiken2 marked this pull request as ready for review December 17, 2024 08:05
@ironAiken2 ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 81fec82 to 092b2a2 Compare December 18, 2024 04:29
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch from 0460eca to b64e582 Compare December 18, 2024 04:29
@ironAiken2 ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 092b2a2 to 986255b Compare December 18, 2024 04:39
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch from b64e582 to 6e6aef7 Compare December 18, 2024 04:39
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to add exporting all data feature also. It's okay to handle this as a different PR.

@ironAiken2 ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 986255b to ac98042 Compare December 18, 2024 06:29
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch from 6e6aef7 to 0e0a36a Compare December 18, 2024 06:29
@ironAiken2 ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from ac98042 to 2479854 Compare December 18, 2024 06:31
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch from 0e0a36a to ce92025 Compare December 18, 2024 06:31
@ironAiken2 ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 2479854 to 9d61c02 Compare December 18, 2024 07:22
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch from ce92025 to c37bda4 Compare December 18, 2024 07:22
@ironAiken2 ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 9d61c02 to 53a7626 Compare December 18, 2024 08:43
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch from c37bda4 to 2186336 Compare December 18, 2024 08:43
@ironAiken2 ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 53a7626 to 2be9bf0 Compare December 18, 2024 08:49
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch 2 times, most recently from 63eafd4 to bb27fd4 Compare December 18, 2024 08:50
@ironAiken2 ironAiken2 changed the base branch from feat/keypair-create-and-modify-modal to feat/remove-legacy-user-create-modal December 18, 2024 08:50
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from bf6d55e to 5bb75cb Compare December 23, 2024 02:21
@ironAiken2 ironAiken2 marked this pull request as draft December 23, 2024 02:21
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch from bb27fd4 to 121a6ce Compare December 23, 2024 04:21
@ironAiken2
Copy link
Contributor Author

Starting with version 24.12.0, we decided to remove the export CSV feature from the WebUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CSV export functionality to the credential page
2 participants