-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export users and credential to csv #2961
feat: export users and credential to csv #2961
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
aa394c7
to
b70cc28
Compare
7aa08f5
to
0d7d98d
Compare
b70cc28
to
81fec82
Compare
9e72899
to
0460eca
Compare
81fec82
to
092b2a2
Compare
0460eca
to
b64e582
Compare
092b2a2
to
986255b
Compare
b64e582
to
6e6aef7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to add exporting all data feature also. It's okay to handle this as a different PR.
986255b
to
ac98042
Compare
6e6aef7
to
0e0a36a
Compare
ac98042
to
2479854
Compare
0e0a36a
to
ce92025
Compare
2479854
to
9d61c02
Compare
ce92025
to
c37bda4
Compare
9d61c02
to
53a7626
Compare
c37bda4
to
2186336
Compare
53a7626
to
2be9bf0
Compare
63eafd4
to
bb27fd4
Compare
bf6d55e
to
5bb75cb
Compare
bb27fd4
to
121a6ce
Compare
Starting with version 24.12.0, we decided to remove the export CSV feature from the WebUI. |
This PR resolves #2956
Changes:
How to test:
Discussions:
Currently, CSV exports are executed based on the data fetched via the request, not the information shown in the table. So, if the key is not the same as the Key of the response data type, or is shown separately in the render function without using response data, you cannot extract that data.
The CSV export function will be changed in the future. We plan to define CSV columns in the same way as Antd's table column definitions to support column ordering and customization of CSV data. This will be a separate issue and stack.
Checklist: (if applicable)