feat: user list using user_nodes query
#2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Dec 11, 2024
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 11, 2024
ironAiken2
force-pushed
the
feat/user-list-page
branch
from
11e7f67 to
b375e78
Compare
ironAiken2
force-pushed
the
feature/user-node-list
branch
from
93f266e to
b3f2278
Compare
ironAiken2
force-pushed
the
feat/user-list-page
branch
from
b375e78 to
59b79b0
Compare
ironAiken2
force-pushed
the
feature/user-node-list
branch
from
b3f2278 to
a9d0ece
Compare
6 tasks
ironAiken2
force-pushed
the
feature/user-node-list
branch
from
a9d0ece to
261b005
Compare
ironAiken2
approved these changes
Dec 12, 2024
agatha197
requested changes
Dec 12, 2024
There was a problem hiding this comment.
- I can't find the description even though the filtering supports the description.
- In the role column, the superadmin is described as 'superadmin' but it is described as 'super admin' in filtering. Let's unify the expressions.
- Please remove the USER | CREDENTIALS tab of the Credentials tab.
yomybaby
force-pushed
the
feat/user-list-page
branch
from
59b79b0 to
682b18e
Compare
yomybaby
force-pushed
the
feature/user-node-list
branch
from
261b005 to
47f2a54
Compare
|
I'll check 1 & 2. The 3 is handled in #2758 |
yomybaby
force-pushed
the
feat/user-list-page
branch
from
682b18e to
0559656
Compare
yomybaby
force-pushed
the
feature/user-node-list
branch
from
47f2a54 to
9c14f4e
Compare
|
Please check again. I resolve 1 and 2. Thank you |
|
I'll remove the USER | CREDENTIALS tab you mentioned so that the current PR can be merged first. |
|
I think 2 is not resolved yet. |
|
Sorry I don't know why it is reverted. I'll push again soon. |
|
And please check the unresolved threads too :) |
yomybaby
force-pushed
the
feature/user-node-list
branch
from
9c14f4e to
dbeccac
Compare
yomybaby
force-pushed
the
feature/user-node-list
branch
from
dbeccac to
baa2e6e
Compare
agatha197
requested changes
Dec 13, 2024
agatha197
requested changes
Dec 13, 2024
ironAiken2
force-pushed
the
feat/user-list-page
branch
from
0559656 to
de17251
Compare
ironAiken2
force-pushed
the
feature/user-node-list
branch
from
baa2e6e to
5cf04e6
Compare
ironAiken2
force-pushed
the
feature/user-node-list
branch
from
66d86df to
a29c647
Compare
Merge activity
|
**Changes:** Migrates the user management interface from Web Components to React, introducing a new `UserNodeList` component that provides enhanced user management capabilities. The new implementation includes: - Active/Inactive user filtering - Advanced property filtering for email, username, role, and description - Table-based user listing with sorting and pagination - User information viewing and settings modification - User deletion functionality with confirmation dialog - Refresh capabilities for real-time updates **Rationale:** This change modernizes the user management interface by leveraging React's component model and state management, while maintaining feature parity with the previous implementation. The migration removes duplicate code and consolidates user management logic into a single, maintainable component.
yomybaby
force-pushed
the
feat/user-list-page
branch
from
de17251 to
60dedfb
Compare
yomybaby
force-pushed
the
feature/user-node-list
branch
from
a29c647 to
cc2f9a1
Compare
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Migrates the user management interface from Web Components to React, introducing a new
UserNodeListcomponent that provides enhanced user management capabilities. The new implementation includes:Rationale:
This change modernizes the user management interface by leveraging React's component model and state management, while maintaining feature parity with the previous implementation. The migration removes duplicate code and consolidates user management logic into a single, maintainable component.