feat: keypair info/setting modal in credential page #2940

ironAiken2 · 2024-12-11T09:59:10Z

This PR resolves #2937 issue

Changes:

Since UserSettingPage is using the KeypairInfoModal, I renamed the component to MyKeypairInfoModal.
Added KeypairInfoModal and KeypairSettingModal for Credential Page.
The KeypairSettingModal is used to create or modify a key pair.
ordering/filtering keypair_list query by user_id is out of scope for this PR because it does not yet provide ordering, filtering on user_id.

How to test:

Access the user credentials & policy page with an account with admin or higher permissions.
Verify that the KeypairInfoModal shows the correct information for the selected keypair.
Verify that the KeypairSettingModal allows you to create and modify keypair information.

Checklist: (if applicable)

Mention to the original issue
Documentation
Minium required manager version
Specific setting for review (eg., KB link, endpoint or how to setup)
Minimum requirements to check during review
Test case(s) to demonstrate the difference of before/after

graphite-app · 2024-12-11T09:59:15Z

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

ironAiken2 · 2024-12-11T09:59:27Z

feat: remove legacy user/credential components #2755 : 2 dependent PRs (#2961 , #2984 )
feat: keypair info/setting modal in credential page #2940 👈 (View in Graphite)
feat: migrate user credential list to react component #2758
feat: user list using user_nodes query #2934
feat: migrate /credentials page to react component #2757
feat: migrate create user modal into react component #2754
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

agatha197

.

react/src/components/KeypairSettingModal.tsx

react/src/components/MyKeypairInfoModal.tsx

agatha197

Modify modal doesn't close automatically after updating.

agatha197

LGTM

yomybaby

LGTM

graphite-app · 2024-12-23T08:08:22Z

Merge activity

Dec 23, 3:08 AM EST: A user added this pull request to the Graphite merge queue.
Dec 23, 3:11 AM EST: A user merged this pull request with the Graphite merge queue.

### This PR resolves [#2937](#2937) issue **Changes:** - Since `UserSettingPage` is using the KeypairInfoModal, I renamed the component to MyKeypairInfoModal. - Added `KeypairInfoModal` and `KeypairSettingModal` for `Credential Page`. - The `KeypairSettingModal` is used to create or modify a key pair. - ordering/filtering keypair_list query by user_id is out of scope for this PR because it does not yet provide ordering, filtering on user_id. **How to test:** - Access the user credentials & policy page with an account with admin or higher permissions. - Verify that the `KeypairInfoModal` shows the correct information for the selected keypair. - Verify that the `KeypairSettingModal` allows you to create and modify keypair information. **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after

github-actions bot assigned ironAiken2 Dec 11, 2024

github-actions bot added the size:M 30~100 LoC label Dec 11, 2024

ironAiken2 mentioned this pull request Dec 11, 2024

feat: migrate user credential list to react component #2758

Merged

6 tasks

ironAiken2 mentioned this pull request Dec 11, 2024

feat: user list using user_nodes query #2934

Merged

ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 485ce28 to c2f4135 Compare December 11, 2024 10:00

github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Dec 11, 2024

ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from c2f4135 to b330220 Compare December 12, 2024 07:04

github-actions bot added area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC and removed size:L 100~500 LoC labels Dec 12, 2024

ironAiken2 requested review from agatha197 and yomybaby and removed request for agatha197 December 12, 2024 07:12

ironAiken2 marked this pull request as ready for review December 12, 2024 07:12

ironAiken2 force-pushed the feat/user-credential-list branch from b19dfdb to 7cc2e99 Compare December 12, 2024 08:06

ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from b330220 to 74c2cf5 Compare December 12, 2024 08:06

This was referenced Dec 12, 2024

feat: migrate create user modal into react component #2754

Merged

feat: remove legacy user/credential components #2755

Merged

feat: migrate /credentials page to react component #2757

Merged

ironAiken2 requested a review from agatha197 December 12, 2024 08:19

yomybaby force-pushed the feat/user-credential-list branch from 7cc2e99 to 8106932 Compare December 12, 2024 09:05

ironAiken2 marked this pull request as draft December 12, 2024 09:13

ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 74c2cf5 to 39cfc44 Compare December 12, 2024 09:29

yomybaby force-pushed the feat/user-credential-list branch from 8106932 to 73d7b5f Compare December 13, 2024 03:10

yomybaby force-pushed the feat/keypair-create-and-modify-modal branch from 39cfc44 to 7d3792f Compare December 13, 2024 03:10

ironAiken2 force-pushed the feat/user-credential-list branch from 73d7b5f to 665742b Compare December 16, 2024 01:38

ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 092b2a2 to 986255b Compare December 18, 2024 04:39

agatha197 requested changes Dec 18, 2024

View reviewed changes

ironAiken2 force-pushed the feat/user-credential-list branch from a35f9a8 to 8b8138c Compare December 18, 2024 06:29

ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 986255b to ac98042 Compare December 18, 2024 06:29

ironAiken2 force-pushed the feat/user-credential-list branch from 8b8138c to ad3c66f Compare December 18, 2024 06:31

ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from ac98042 to 2479854 Compare December 18, 2024 06:31

ironAiken2 force-pushed the feat/user-credential-list branch from ad3c66f to 6405a37 Compare December 18, 2024 07:22

ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 2479854 to 9d61c02 Compare December 18, 2024 07:22

ironAiken2 requested a review from agatha197 December 18, 2024 07:23

agatha197 requested changes Dec 18, 2024

View reviewed changes

ironAiken2 force-pushed the feat/user-credential-list branch from 6405a37 to 642664f Compare December 18, 2024 08:42

ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch 2 times, most recently from 53a7626 to 2be9bf0 Compare December 18, 2024 08:49

ironAiken2 requested a review from agatha197 December 18, 2024 08:49

agatha197 approved these changes Dec 18, 2024

View reviewed changes

ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 2be9bf0 to 6ac31c3 Compare December 23, 2024 02:21

ironAiken2 requested a review from agatha197 December 23, 2024 02:21

ironAiken2 force-pushed the feat/user-credential-list branch from 642664f to 5490140 Compare December 23, 2024 06:43

ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 6ac31c3 to 8d3b258 Compare December 23, 2024 06:43

ironAiken2 mentioned this pull request Dec 23, 2024

fix: remove the Export CSV feature from the WebUI #2984

Closed

6 tasks

yomybaby force-pushed the feat/keypair-create-and-modify-modal branch from 8d3b258 to 1f4dc18 Compare December 23, 2024 08:06

yomybaby approved these changes Dec 23, 2024

View reviewed changes

yomybaby force-pushed the feat/user-credential-list branch from 5490140 to e07e4bc Compare December 23, 2024 08:09

yomybaby force-pushed the feat/keypair-create-and-modify-modal branch from 1f4dc18 to ec8d643 Compare December 23, 2024 08:09

Base automatically changed from feat/user-credential-list to main December 23, 2024 08:11

graphite-app bot merged commit ec8d643 into main Dec 23, 2024
4 checks passed

graphite-app bot deleted the feat/keypair-create-and-modify-modal branch December 23, 2024 08:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: keypair info/setting modal in credential page #2940

feat: keypair info/setting modal in credential page #2940

ironAiken2 commented Dec 11, 2024 •

edited

Loading

graphite-app bot commented Dec 11, 2024

ironAiken2 commented Dec 11, 2024 •

edited

Loading

agatha197 left a comment •

edited

Loading

agatha197 left a comment

agatha197 left a comment

yomybaby left a comment

graphite-app bot commented Dec 23, 2024 •

edited

Loading

feat: keypair info/setting modal in credential page #2940

feat: keypair info/setting modal in credential page #2940

Conversation

ironAiken2 commented Dec 11, 2024 • edited Loading

This PR resolves #2937 issue

graphite-app bot commented Dec 11, 2024

Your org requires the Graphite merge queue for merging into main

ironAiken2 commented Dec 11, 2024 • edited Loading

How to use the Graphite Merge Queue

agatha197 left a comment • edited Loading

Choose a reason for hiding this comment

agatha197 left a comment

Choose a reason for hiding this comment

agatha197 left a comment

Choose a reason for hiding this comment

yomybaby left a comment

Choose a reason for hiding this comment

graphite-app bot commented Dec 23, 2024 • edited Loading

Merge activity

ironAiken2 commented Dec 11, 2024 •

edited

Loading

ironAiken2 commented Dec 11, 2024 •

edited

Loading

agatha197 left a comment •

edited

Loading

graphite-app bot commented Dec 23, 2024 •

edited

Loading