-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove legacy user/credential components #2755
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about moving this PR to the parent of #2757, and removing the credential view file?
ba3f04c
to
c98cc2a
Compare
1417227
to
2d2084d
Compare
c98cc2a
to
b23ed6a
Compare
2d2084d
to
88112af
Compare
b23ed6a
to
be33acc
Compare
1f06be9
to
42880b8
Compare
be33acc
to
c13fd6b
Compare
42880b8
to
938d531
Compare
c13fd6b
to
efb506d
Compare
938d531
to
747bd07
Compare
efb506d
to
11166c6
Compare
747bd07
to
11e7f67
Compare
b375e78
to
59b79b0
Compare
aaae3c2
to
48ee539
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6e6aef7
to
0e0a36a
Compare
48ee539
to
9fc39e6
Compare
0e0a36a
to
ce92025
Compare
9fc39e6
to
f135044
Compare
ce92025
to
c37bda4
Compare
f135044
to
a9cc16f
Compare
c37bda4
to
2186336
Compare
a9cc16f
to
6ece38c
Compare
2186336
to
63eafd4
Compare
6832986
to
bf6d55e
Compare
2be9bf0
to
6ac31c3
Compare
bf6d55e
to
5bb75cb
Compare
6ac31c3
to
8d3b258
Compare
5bb75cb
to
5fddec8
Compare
8d3b258
to
1f4dc18
Compare
5fddec8
to
2269587
Compare
Merge activity
|
**Changes:** This PR removes the functionality for adding new users directly from the credential view. Specifically: - Removed the `newUserDialog` query and related dialog HTML - Deleted the `_launchUserAddDialog` and `_addUser` methods - Removed password validation methods: `_validatePassword`, `_validatePassword1`, `_validatePassword2` - Deleted the `_togglePasswordVisibility` method **Rationale:** The user creation functionality has likely been moved to a separate component or is being handled differently in the application. This change simplifies the credential view by focusing it on credential management rather than user management. **Impact:** - Administrators will no longer be able to add new users directly from the credential view - The user interface for the credential view will be cleaner, without the "Add User" dialog - Any code relying on the removed methods or dialog will need to be updated **Checklist:** - [ ] Update documentation to reflect the removal of user creation from the credential view - [ ] Ensure that user creation functionality is available elsewhere in the application - [ ] Test to confirm that credential management features still work as expected - [ ] Verify that removing these elements doesn't break any existing functionality
1f4dc18
to
ec8d643
Compare
2269587
to
a0f588d
Compare
Changes:
This PR removes the functionality for adding new users directly from the credential view. Specifically:
newUserDialog
query and related dialog HTML_launchUserAddDialog
and_addUser
methods_validatePassword
,_validatePassword1
,_validatePassword2
_togglePasswordVisibility
methodRationale:
The user creation functionality has likely been moved to a separate component or is being handled differently in the application. This change simplifies the credential view by focusing it on credential management rather than user management.
Impact:
Checklist: