Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove legacy user/credential components #2755

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Oct 16, 2024

Changes:

This PR removes the functionality for adding new users directly from the credential view. Specifically:

  • Removed the newUserDialog query and related dialog HTML
  • Deleted the _launchUserAddDialog and _addUser methods
  • Removed password validation methods: _validatePassword, _validatePassword1, _validatePassword2
  • Deleted the _togglePasswordVisibility method

Rationale:

The user creation functionality has likely been moved to a separate component or is being handled differently in the application. This change simplifies the credential view by focusing it on credential management rather than user management.

Impact:

  • Administrators will no longer be able to add new users directly from the credential view
  • The user interface for the credential view will be cleaner, without the "Add User" dialog
  • Any code relying on the removed methods or dialog will need to be updated

Checklist:

  • Update documentation to reflect the removal of user creation from the credential view
  • Ensure that user creation functionality is available elsewhere in the application
  • Test to confirm that credential management features still work as expected
  • Verify that removing these elements doesn't break any existing functionality

Copy link

graphite-app bot commented Oct 16, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

ironAiken2 commented Oct 16, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the size:L 100~500 LoC label Oct 16, 2024
@ironAiken2 ironAiken2 requested a review from yomybaby October 16, 2024 08:44
@ironAiken2 ironAiken2 marked this pull request as ready for review October 17, 2024 02:00
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving this PR to the parent of #2757, and removing the credential view file?

Copy link
Contributor Author

I've organized the stack so that PR #2754 is merged and used first, but I don't think deleting files is relevant to the actual use of the feature, so I'll stack it above #2757 as you said!

@ironAiken2 ironAiken2 marked this pull request as draft October 18, 2024 04:46
@ironAiken2 ironAiken2 changed the base branch from feat/react-create-user-modal to feat/user-list-page October 18, 2024 04:48
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from ba3f04c to c98cc2a Compare October 18, 2024 04:48
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from c98cc2a to b23ed6a Compare October 18, 2024 05:06
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from b23ed6a to be33acc Compare October 18, 2024 05:09
@yomybaby yomybaby force-pushed the feat/user-list-page branch 2 times, most recently from 1f06be9 to 42880b8 Compare November 6, 2024 08:18
@yomybaby yomybaby force-pushed the feat/remove-legacy-user-create-modal branch from be33acc to c13fd6b Compare November 6, 2024 08:18
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from c13fd6b to efb506d Compare December 10, 2024 04:40
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from efb506d to 11166c6 Compare December 10, 2024 04:44
@yomybaby yomybaby force-pushed the feat/user-list-page branch from 747bd07 to 11e7f67 Compare December 11, 2024 03:33
@ironAiken2 ironAiken2 force-pushed the feat/user-list-page branch 2 times, most recently from b375e78 to 59b79b0 Compare December 11, 2024 07:10
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from aaae3c2 to 48ee539 Compare December 18, 2024 04:39
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch from 6e6aef7 to 0e0a36a Compare December 18, 2024 06:29
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from 48ee539 to 9fc39e6 Compare December 18, 2024 06:29
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch from 0e0a36a to ce92025 Compare December 18, 2024 06:31
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from 9fc39e6 to f135044 Compare December 18, 2024 06:31
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch from ce92025 to c37bda4 Compare December 18, 2024 07:22
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from f135044 to a9cc16f Compare December 18, 2024 07:22
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch from c37bda4 to 2186336 Compare December 18, 2024 08:43
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from a9cc16f to 6ece38c Compare December 18, 2024 08:43
@ironAiken2 ironAiken2 force-pushed the feat/export-credential-to-csv branch from 2186336 to 63eafd4 Compare December 18, 2024 08:49
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch 2 times, most recently from 6832986 to bf6d55e Compare December 18, 2024 08:50
@ironAiken2 ironAiken2 changed the base branch from feat/export-credential-to-csv to feat/keypair-create-and-modify-modal December 18, 2024 08:50
@ironAiken2 ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 2be9bf0 to 6ac31c3 Compare December 23, 2024 02:21
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from bf6d55e to 5bb75cb Compare December 23, 2024 02:21
@ironAiken2 ironAiken2 changed the title feat: remove legacy user creation modal feat: remove legacy user/credential components Dec 23, 2024
@ironAiken2 ironAiken2 force-pushed the feat/keypair-create-and-modify-modal branch from 6ac31c3 to 8d3b258 Compare December 23, 2024 06:43
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from 5bb75cb to 5fddec8 Compare December 23, 2024 06:43
@yomybaby yomybaby force-pushed the feat/keypair-create-and-modify-modal branch from 8d3b258 to 1f4dc18 Compare December 23, 2024 08:06
@yomybaby yomybaby force-pushed the feat/remove-legacy-user-create-modal branch from 5fddec8 to 2269587 Compare December 23, 2024 08:06
Copy link

graphite-app bot commented Dec 23, 2024

Merge activity

**Changes:**

This PR removes the functionality for adding new users directly from the credential view. Specifically:

- Removed the `newUserDialog` query and related dialog HTML
- Deleted the `_launchUserAddDialog` and `_addUser` methods
- Removed password validation methods: `_validatePassword`, `_validatePassword1`, `_validatePassword2`
- Deleted the `_togglePasswordVisibility` method

**Rationale:**

The user creation functionality has likely been moved to a separate component or is being handled differently in the application. This change simplifies the credential view by focusing it on credential management rather than user management.

**Impact:**

- Administrators will no longer be able to add new users directly from the credential view
- The user interface for the credential view will be cleaner, without the "Add User" dialog
- Any code relying on the removed methods or dialog will need to be updated

**Checklist:**

- [ ] Update documentation to reflect the removal of user creation from the credential view
- [ ] Ensure that user creation functionality is available elsewhere in the application
- [ ] Test to confirm that credential management features still work as expected
- [ ] Verify that removing these elements doesn't break any existing functionality
@yomybaby yomybaby force-pushed the feat/keypair-create-and-modify-modal branch from 1f4dc18 to ec8d643 Compare December 23, 2024 08:09
@yomybaby yomybaby force-pushed the feat/remove-legacy-user-create-modal branch from 2269587 to a0f588d Compare December 23, 2024 08:10
Base automatically changed from feat/keypair-create-and-modify-modal to main December 23, 2024 08:11
@graphite-app graphite-app bot merged commit a0f588d into main Dec 23, 2024
4 checks passed
@graphite-app graphite-app bot deleted the feat/remove-legacy-user-create-modal branch December 23, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants