Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ChiselSim] Add expose/observe methods to simulator for submodule drilling #4206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

carlosedp
Copy link
Contributor

@carlosedp carlosedp commented Jun 21, 2024

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

The method expose allows one to bring to a wrapped module, signals from instantiated sub-modules so they can be tested by peek/poke. This avoid cluttering the original module with signals that would be used only by the test harness.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@carlosedp carlosedp changed the title Add expose/observe methods to simulator for submodule drilling [ChiselSim] Add expose/observe methods to simulator for submodule drilling Jun 21, 2024
@sequencer
Copy link
Member

I personally would not accept this. This feature should be resolved by Probe API which natively supported by Chisel. Boring will affect the RTL, which is always a bad idea in RTL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants