Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test for user mode #185

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

wsipak
Copy link
Collaborator

@wsipak wsipak commented Jun 11, 2024

  1. Bring back USER_MODE in core settings.
  2. Add new tests for user mode using riscv-dv
  3. Add pre-generated code for the tests
  4. Specify privilege modes to be used in simulators in riscv-dv

Currently, riscv-dv doesn't allow specifying privilege modes to be enabled in simulators. There's inconsistence because whisper uses only Machine mode by default, while spike also enables Supervisor and User modes.
With this change, we're explicitly enabling U mode.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

design/dec/el2_dec_decode_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_decode_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_decode_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_tlu_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_tlu_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_tlu_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_tlu_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_tlu_ctl.sv Outdated Show resolved Hide resolved
design/el2_veer.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_pmp.sv Outdated Show resolved Hide resolved
design/el2_veer.sv Outdated Show resolved Hide resolved
design/el2_veer.sv Outdated Show resolved Hide resolved
design/el2_veer.sv Outdated Show resolved Hide resolved
design/include/el2_def.sv Outdated Show resolved Hide resolved
design/include/el2_def.sv Outdated Show resolved Hide resolved
@wsipak wsipak force-pushed the wsip/u_mode branch 4 times, most recently from 32dbff4 to 64bf37b Compare June 24, 2024 13:08
Copy link

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

design/dec/el2_dec_decode_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_decode_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_decode_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/dec/el2_dec_pmp_ctl.sv Outdated Show resolved Hide resolved
design/el2_veer.sv Outdated Show resolved Hide resolved
Copy link

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

1 similar comment
Copy link

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

Copy link

github-actions bot commented Jul 4, 2024

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

Copy link

github-actions bot commented Jul 5, 2024

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

Copy link

github-actions bot commented Jul 5, 2024

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

Copy link

github-actions bot commented Jul 5, 2024

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@wsipak wsipak marked this pull request as ready for review July 5, 2024 19:06
Copy link

github-actions bot commented Jul 8, 2024

Links to coverage and verification reports for this PR (#185) are available at https://chipsalliance.github.io/Cores-VeeR-EL2/

@wsipak
Copy link
Collaborator Author

wsipak commented Jul 9, 2024

Tests failed on the main branch so I'm going to see what happened there first, and then check the CI results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant