Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_mpc_lateral_controller): use parameter from param.yaml file in unit_test #7057

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
+130 −57

style(pre-commit): autofix

34d5f2b
Select commit
Loading
Failed to load commit list.
Draft

feat(autoware_mpc_lateral_controller): use parameter from param.yaml file in unit_test #7057

style(pre-commit): autofix
34d5f2b
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 24, 2024 in 40s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method test_mpc.cpp: initParam

Annotations

Check warning on line 185 in control/autoware_mpc_lateral_controller/test/test_mpc.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method 

initParam has 79 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis