Offboard reserve mode ID #28939
Merged
Offboard reserve mode ID #28939
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I'd vote for using mode 29 or 30. 29 is an odd number but that's OK. |
I'll do 30! |
|
Does this have to line up with @IamPete1 's work on "scripted modes", where it will be possible to create new modes in Lua script that inherit from Guided? |
Yea that's the idea. We need to work together on a long term design, this is just a reservation if we choose to stop using guided for offboard on plane, and make it consistent between all the vehicles. |
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
force-pushed
the
offboard-reserve-id
branch
from
4f7b871 to
a570e28
Compare
tridge
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reserve mode 30 for offboard so it's the same on all vehicles.