Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logger.fine statements #2793

Merged
merged 3 commits into from
Jan 2, 2018
Merged

Remove logger.fine statements #2793

merged 3 commits into from
Jan 2, 2018

Conversation

DanVanAtta
Copy link
Member

Few reasons to remove:

  • reduces code, fewer things to maintain "shave and a haircut"

Benefit we are losing:

  • debugging value. I suspect these were mostly useful when developing the features, as is it can make it a bit hard to read and I'm not sure if we would want these exact debug statemetns if we modify related areas of the code. Seems to favor the cost/benefit to remove so we can maintain the code more easily.

In another PR i removed a similar logger.fine statement, figured it made sense to fix that everywhere rather than one or two at a time.

Few reasons to remove:
- reduces code, fewer things to maintain "shave and a haircut"

Benefit we are losing:
- debugging value. I suspect these were mostly useful when developing the features, as is it can make it a bit hard to read and I'm not sure if we would want these exact debug statemetns if we modify related areas of the code. Seems to favor the cost/benefit to remove so we can maintain the code more easily.
@RoiEXLab
Copy link
Member

RoiEXLab commented Jan 2, 2018

@DanVanAtta the build is failing due to some checkstyle violations.

@DanVanAtta DanVanAtta self-assigned this Jan 2, 2018
@codecov-io
Copy link

codecov-io commented Jan 2, 2018

Codecov Report

Merging #2793 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2793      +/-   ##
============================================
+ Coverage     20.09%   20.13%   +0.03%     
- Complexity     5746     5751       +5     
============================================
  Files           814      815       +1     
  Lines         73364    73289      -75     
  Branches      12190    12154      -36     
============================================
+ Hits          14745    14756      +11     
+ Misses        56490    56428      -62     
+ Partials       2129     2105      -24
Impacted Files Coverage Δ Complexity Δ
...ategy/engine/lobby/server/LobbyGameController.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...gine/lobby/server/db/BannedUsernameController.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...a/games/strategy/triplea/ui/AbstractMovePanel.java 0.78% <ø> (+0.01%) 1 <0> (ø) ⬇️
...egy/engine/lobby/server/db/MutedMacController.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rc/main/java/games/strategy/net/nio/NioReader.java 72.63% <ø> (+4.98%) 17 <0> (ø) ⬇️
...ames/strategy/engine/message/RemoteMethodCall.java 84.84% <ø> (+4.84%) 39 <0> (ø) ⬇️
...strategy/net/nio/ClientQuarantineConversation.java 55.84% <ø> (+9.1%) 13 <0> (ø) ⬇️
...gy/engine/lobby/server/db/BannedMacController.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...gine/framework/startup/launcher/LocalLauncher.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...in/java/games/strategy/triplea/image/ImageRef.java 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcab9a4...b54f5d2. Read the comment docs.

@DanVanAtta DanVanAtta removed their assignment Jan 2, 2018
@RoiEXLab RoiEXLab merged commit 2d64a67 into triplea-game:master Jan 2, 2018
@DanVanAtta DanVanAtta deleted the remove_logger_fine branch January 2, 2018 08:27
@ssoloff ssoloff mentioned this pull request Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants