Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused fields #2826

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Conversation

ssoloff
Copy link
Member

@ssoloff ssoloff commented Jan 10, 2018

I believe all of these fields are no longer used after #2793.

@codecov-io
Copy link

Codecov Report

Merging #2826 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2826      +/-   ##
============================================
- Coverage     20.13%   20.13%   -0.01%     
+ Complexity     5747     5745       -2     
============================================
  Files           815      815              
  Lines         73269    73258      -11     
  Branches      12136    12136              
============================================
- Hits          14752    14748       -4     
+ Misses        56426    56417       -9     
- Partials       2091     2093       +2
Impacted Files Coverage Δ Complexity Δ
...ngine/lobby/server/db/MutedUsernameController.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...a/games/strategy/triplea/ui/AbstractMovePanel.java 0% <ø> (-0.79%) 0 <0> (-1)
...mes/strategy/engine/data/CompositeRouteFinder.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...gy/engine/lobby/server/db/BannedMacController.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...tegy/engine/delegate/DelegateExecutionManager.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...egy/engine/lobby/server/db/MutedMacController.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...gine/lobby/server/db/BannedUsernameController.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...gine/framework/startup/launcher/LocalLauncher.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ine/framework/startup/launcher/ServerLauncher.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...in/java/games/strategy/triplea/image/ImageRef.java 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438b9a2...5548154. Read the comment docs.

@RoiEXLab RoiEXLab merged commit 5694bd4 into triplea-game:master Jan 10, 2018
@ssoloff ssoloff deleted the remove-unused-fields branch January 10, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants