Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logger.fine statements #2793

Merged
merged 3 commits into from
Jan 2, 2018
Merged

Remove logger.fine statements #2793

merged 3 commits into from
Jan 2, 2018

Commits on Jan 2, 2018

  1. Remove logger.fine statements

    Few reasons to remove:
    - reduces code, fewer things to maintain "shave and a haircut"
    
    Benefit we are losing:
    - debugging value. I suspect these were mostly useful when developing the features, as is it can make it a bit hard to read and I'm not sure if we would want these exact debug statemetns if we modify related areas of the code. Seems to favor the cost/benefit to remove so we can maintain the code more easily.
    DanVanAtta committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    a5d08cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c75067 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b54f5d2 View commit details
    Browse the repository at this point in the history