Fix division by zero and check for isFinite() to fix comparator issue. #12697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would verify whether triplea-game#12693 is caused by non-finite values.
|
Aha, looks like this precondition actually failed in testAiGameMovingConsumedUnitsToFactories! So that does show it's probably this that is responsible. Will need to debug. |
asvitkine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check was intended to verify whether #12693 was caused by non-finite values.
However, tests caught that this could actually trigger due to a division by zero.
I suspect this should therefore fix #12693
Notes to Reviewer