Fix division by zero and check for isFinite() to fix comparator issue. (

#12697)

* Add check for isFinite() to diagnose comparator issue.

This would verify whether #12693 is caused by non-finite values.

* Fix NaN due to division by zero.

* Uncommit file accidentally committed.

game-app/game-core/src/main/java/games/strategy/triplea/ai/pro/util/ProSortMoveOptionsUtils.java

@@ -1,5 +1,6 @@
 package games.strategy.triplea.ai.pro.util;
 
+import com.google.common.base.Preconditions;
 import games.strategy.engine.data.GameData;
 import games.strategy.engine.data.GamePlayer;
 import games.strategy.engine.data.GameState;
@@ -230,10 +231,12 @@ private static double calculateAttackEfficiency(
         minPower = powerDifference;
       }
     }
-
     if (unit.getUnitAttachment().getIsAir()) {
       minPower *= 10;
     }
-    return (double) minPower / proData.getUnitValue(unit.getType());
+    final double unitValue = proData.getUnitValue(unit.getType());
+    final double result = unitValue == 0.0 ? 0.0 : (double) minPower / unitValue;
+    Preconditions.checkState(Double.isFinite(result));
+    return result;
   }
 }