Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix division by zero and check for isFinite() to fix comparator issue. #12697

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Fix division by zero and check for isFinite() to fix comparator issue. #12697

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63148a8
Add check for isFinite() to diagnose comparator issue.
asvitkine Jul 5, 2024
06b6f12
Fix NaN due to division by zero.
asvitkine Jul 5, 2024
4b50a6d
Uncommit file accidentally committed.
asvitkine Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...p/game-core/src/main/java/games/strategy/triplea/ai/pro/util/ProSortMoveOptionsUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package games.strategy.triplea.ai.pro.util;

import com.google.common.base.Preconditions;
import games.strategy.engine.data.GameData;
import games.strategy.engine.data.GamePlayer;
import games.strategy.engine.data.GameState;
Expand Down Expand Up @@ -230,10 +231,12 @@ private static double calculateAttackEfficiency(
minPower = powerDifference;
}
}

if (unit.getUnitAttachment().getIsAir()) {
minPower *= 10;
}
return (double) minPower / proData.getUnitValue(unit.getType());
final double unitValue = proData.getUnitValue(unit.getType());
final double result = unitValue == 0.0 ? 0.0 : (double) minPower / unitValue;
Preconditions.checkState(Double.isFinite(result));
return result;
}
}