feat: add support for OS specific keychains #1703
Open
+599
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
force-pushed
the
feat/os_keychain
branch
from
87a3101
to
432ca74
Compare
5 tasks
5 tasks
elizabethengelman
force-pushed
the
feat/os_keychain
branch
from
8732084
to
a6756f1
Compare
- previously we were creating a new keyring entry for each interaction with the keyring - this change will allow us use a mock keyring entry for testing
elizabethengelman
force-pushed
the
feat/os_keychain
branch
from
072a3af
to
e120595
Compare
elizabethengelman
changed the base branch from
feat/add_stellar_ledger
to
main
required for keyring crate
elizabethengelman
force-pushed
the
feat/os_keychain
branch
from
bd666c6
to
57ba3a4
Compare
elizabethengelman
force-pushed
the
feat/os_keychain
branch
from
8366b5c
to
6a4b0ff
Compare
elizabethengelman
force-pushed
the
feat/os_keychain
branch
from
6a4b0ff
to
f263d8d
Compare
| @@ -39,6 +49,10 @@ pub struct Cmd { | |||
| #[arg(long, short = 's')] | |||
| pub as_secret: bool, | |||
|
|
|||
| /// Save in OS-specific secure store | |||
| #[arg(long)] | |||
| pub secure_store: bool, | |||
There was a problem hiding this comment.
would it make sense to add an alias for this arg: keychain for mac, secret-service for linux and windows-credential-manager for windows?
| @@ -46,7 +46,7 @@ jobs: | |||
| - run: rustup target add ${{ matrix.sys.target }} | |||
|
|
|||
| - if: matrix.sys.target == 'aarch64-unknown-linux-gnu' | |||
| run: sudo apt-get update && sudo apt-get -y install gcc-aarch64-linux-gnu g++-aarch64-linux-gnu libudev-dev | |||
| run: sudo apt-get update && sudo apt-get -y install gcc-aarch64-linux-gnu g++-aarch64-linux-gnu libudev-dev libdbus-1-dev | |||
There was a problem hiding this comment.
The keyring crate requires this pkg as a dependency, so I am including it on several of these linux workflows. I just wanted to point this out as a dependency and see if there is any other way I should handle this.
5 tasks
this change was made so that we can concat the KeyName with secure story prefix and service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1481
I updated this branch to point at main instead of feat/add_stellar_ledger so we wouldn't have too many PRs stacked on each other.
This adds support for using secrets stored in OS specific key rings.
cargo run keys generate --secure-store ee-25-a --network local --no-fundcargo run keys generate --secure-store ee-25-b --network local --fundcargo run keys fund ee-25-b --network localcargo run keys address ee-25-acargo run keys show ee-25-ashould not display the secure store's secret and return an error:❌ error: Secure Store does not reveal secret key