Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign with system keychain #1481

Open
janewang opened this issue Jul 23, 2024 · 9 comments · May be fixed by #1703
Open

Sign with system keychain #1481

janewang opened this issue Jul 23, 2024 · 9 comments · May be fixed by #1703
Assignees

Comments

@janewang
Copy link
Contributor

What problem does your feature solve?

Allows users to use accounts not stored by the CLI.

What would you like to see?

Keychain - For macos:
https://github.com/near/near-cli-rs/blob/9ef098edcb2eca131592feb4917f3715dceb36a2/src/transaction_signature_options/sign_with_macos_keychain/mod.rs

@leighmcculloch
Copy link
Member

leighmcculloch commented Jul 24, 2024

What's the equivalent on Windows? This issue is probably only meaningfully impactful if we address keychain-like capability across multiple platforms because plenty of developers are using windows.

@janewang janewang moved this from Backlog (Not Ready) to Backlog (Ready for Design) in DevX Sep 24, 2024
@BernalHQ
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi, my name is Bernal, and I’m a software developer with four years of experience. I’m passionate about contributing to projects and learn, and I would love the opportunity to contribute to this project

How I plan on tackling this issue

The first step is to understand the project and how it works. Once I have a good understanding of it, I’ll propose a solution to the issue. After that, I’ll implement the solution and run some tests to ensure everything works correctly.

@gregemax
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

have a strong background in JavaScript, TypeScript, and Go, working with secure key management in various projects. I’ve integrated system keychains and external authentication methods, ensuring seamless user experiences with enhanced security.

How I plan on tackling this issue

I would first explore the macOS keychain integration using the linked Rust code as a reference. Then, I would design an abstraction layer that securely interacts with the system’s keychain, ensuring compatibility with JavaScript, TypeScript, and Go, allowing users to sign transactions without storing sensitive keys in the CLI.

@Luluameh
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have experience in JavaScript and TypeScript, with a focus on CLI development and integration with system features. I understand the importance of enhancing user account management and security.

How I plan on tackling this issue

I’d review the existing signing implementation and integrate the macOS keychain functionality as outlined in the provided link. This would involve adapting the code to ensure secure access to accounts not stored by the CLI, while maintaining usability for users.

@od-hunter
Copy link

Hi @janewang , can I work on this please?

@janewang
Copy link
Contributor Author

Removing ODHack8 as the current batch wrapped up

@od-hunter
Copy link

Removing ODHack8 as the current batch wrapped up

So can I work on this please?

@janewang janewang moved this from Backlog (Ready for Design) to Todo (Ready for Dev) in DevX Nov 5, 2024
@janewang
Copy link
Contributor Author

janewang commented Nov 5, 2024

@elizabethengelman has more capacity to take on this work

@elizabethengelman
Copy link
Contributor

elizabethengelman commented Nov 20, 2024

  • stellar keys generate --keychain --no-fund
  • stellar keys generate --keychain --fund
  • stellar keys address
  • stellar keys fund
  • stellar keys rm
  • stellar keys add
  • stellar keys show
  • stellar tx sign

@elizabethengelman elizabethengelman linked a pull request Nov 20, 2024 that will close this issue
34 tasks
@elizabethengelman elizabethengelman linked a pull request Nov 20, 2024 that will close this issue
34 tasks
@elizabethengelman elizabethengelman moved this from In Progress to Needs Review in DevX Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Review
Development

Successfully merging a pull request may close this issue.

8 participants