Feat/os keychain followup #1770
Draft
+63
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
elizabethengelman
force-pushed
the
feat/os-keychain-followup
branch
2 times, most recently
from
244508d
to
a97ccbb
Compare
elizabethengelman
force-pushed
the
feat/os_keychain
branch
from
072a3af
to
e120595
Compare
elizabethengelman
force-pushed
the
feat/os-keychain-followup
branch
3 times, most recently
from
df3543a
to
3311a50
Compare
elizabethengelman
force-pushed
the
feat/os_keychain
branch
from
6a4b0ff
to
f263d8d
Compare
elizabethengelman
force-pushed
the
feat/os-keychain-followup
branch
from
3311a50
to
a451400
Compare
elizabethengelman
force-pushed
the
feat/os-keychain-followup
branch
from
a451400
to
d63c376
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR is based on #1703 and adds some additional compatibility with the secure store like
keys rmandkeys add.keys rmkeys addWhy
I wanted to keep #1703 from getting too big so it was easier to review.
Known limitations
[TODO or N/A]