-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A subscriptions transport coalescer #3316
base: 10-02_Convert_websocket_transport_to_channel
Are you sure you want to change the base?
A subscriptions transport coalescer #3316
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @steveluscher and the rest of your teammates on Graphite |
f44efa0
to
46b9944
Compare
1d43b65
to
280bb5c
Compare
46b9944
to
7d7c686
Compare
280bb5c
to
4d8926d
Compare
7d7c686
to
977e753
Compare
4d8926d
to
02f25ce
Compare
977e753
to
28aad7a
Compare
02f25ce
to
670630c
Compare
28aad7a
to
eef971e
Compare
670630c
to
10fbbcf
Compare
eef971e
to
4e1350c
Compare
10fbbcf
to
43deb1c
Compare
4e1350c
to
5b6a7be
Compare
43deb1c
to
59c3fa8
Compare
e927f6c
to
100141c
Compare
59c3fa8
to
4b1de9b
Compare
100141c
to
859d964
Compare
4b1de9b
to
04d3cc9
Compare
859d964
to
7557358
Compare
04d3cc9
to
d64134f
Compare
4518435
to
c3a3253
Compare
d64134f
to
f840323
Compare
c3a3253
to
6974ccf
Compare
f840323
to
f77f8a0
Compare
Summary
Given two identical subscriptions, we should not send the request to the server twice. This higher-order transport watches for identical subscriptions over the same transport and returns the same
DataPublisher
to both.Note
It is true that the server coalesces subscriptions on the backend, but coalescing them on the client is still worthwhile in that it reduces chatter over the wire (ie. the subsequent subscription requests don't even get made) and speeds up subscription time on the client for identical subscriptions.