Unhook all of the subscription augmenters so that we can refactor and build them back up, one by one #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e4260af The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
steveluscher
force-pushed
the
10-02-a_package_that_makes_it_easier_to_work_with_subscribable_objects
branch
from
74846f3
to
7ea0591
Compare
steveluscher
force-pushed
the
10-02-unhook_all_of_the_subscription_augmenters_so_that_we_can_refactor_and_build_them_back_up_one_by_one
branch
from
5b8c742
to
ad092cf
Compare
This was referenced Oct 4, 2024
Merged
Merged
lorisleiva
approved these changes
Oct 4, 2024
steveluscher
force-pushed
the
10-02-a_package_that_makes_it_easier_to_work_with_subscribable_objects
branch
from
7ea0591
to
cef0d13
Compare
steveluscher
changed the base branch from
10-02-a_package_that_makes_it_easier_to_work_with_subscribable_objects
to
graphite-base/3302
… build them back up, one by one
steveluscher
force-pushed
the
10-02-unhook_all_of_the_subscription_augmenters_so_that_we_can_refactor_and_build_them_back_up_one_by_one
branch
from
ad092cf
to
e4260af
Compare
Merge activity
|
steveluscher
deleted the
10-02-unhook_all_of_the_subscription_augmenters_so_that_we_can_refactor_and_build_them_back_up_one_by_one
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's extremely hard to change these APIs one at a time, so we're going to unhook all of these transport augmenters, then build them back up one at a time.