A channel augmenter that encodes and decodes messages as JSON #3309
+63
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Oct 4, 2024
This was referenced Oct 4, 2024
Merged
Merged
lorisleiva
approved these changes
Oct 4, 2024
Comment on lines
6
to
8
| return { | ||
| ...channel, | ||
| on(type, listener, options) { |
There was a problem hiding this comment.
Would it make sense to Object.freeze this?
I know technically the RpcSubscriptionsChannel type only has two functions (send and on) but since we're destructuring the inner object here, it may be useful to freeze it.
steveluscher
force-pushed
the
10-02-Introducing_channels
branch
from
7e8d6ca
to
f44dc4a
Compare
steveluscher
force-pushed
the
10-02-a_channel_augmenter_that_encodes_and_decodes_messages_as_json
branch
from
fd5fc49
to
1ac504b
Compare
steveluscher
changed the base branch from
10-02-Introducing_channels
to
graphite-base/3309
steveluscher
force-pushed
the
10-02-a_channel_augmenter_that_encodes_and_decodes_messages_as_json
branch
from
1ac504b
to
a721e9a
Compare
steveluscher
force-pushed
the
graphite-base/3309
branch
from
f44dc4a
to
d32e6d6
Compare
steveluscher
force-pushed
the
10-02-a_channel_augmenter_that_encodes_and_decodes_messages_as_json
branch
3 times, most recently
from
3007e83
to
12931ce
Compare
steveluscher
changed the base branch from
master
to
10-04-revert_no_argument_conditional_type_from_3301
Merge activity
|
steveluscher
changed the base branch from
10-04-revert_no_argument_conditional_type_from_3301
to
graphite-base/3309
steveluscher
force-pushed
the
10-02-a_channel_augmenter_that_encodes_and_decodes_messages_as_json
branch
from
12931ce
to
0d9069a
Compare
steveluscher
deleted the
10-02-a_channel_augmenter_that_encodes_and_decodes_messages_as_json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The new web socket channel speaks in strings/buffers. For general use in the JSON RPC Subscriptions API we need it to take in JavaScript objects, send JSON strings over the wire, and parse the strings that come back as JSON.
This is a higher-order component that wraps a
RpcSubscriptionsChannelthat speaks in strings, and makes it speak in JavaScript objects.