Convert the websocket transport to a channel #3314
Open
+1,069
−1,253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Oct 4, 2024
Merged
Merged
This was referenced Oct 4, 2024
steveluscher
force-pushed
the
10-02_Convert_websocket_transport_to_channel
branch
from
4562029
to
3b6f5ce
Compare
steveluscher
force-pushed
the
10-02-a_channel_augmenter_that_autopings_the_channel
branch
from
54ef405
to
35dc1bd
Compare
steveluscher
force-pushed
the
10-02_Convert_websocket_transport_to_channel
branch
from
3b6f5ce
to
67daefe
Compare
steveluscher
force-pushed
the
10-02-a_channel_augmenter_that_autopings_the_channel
branch
from
35dc1bd
to
0f0bcc7
Compare
steveluscher
force-pushed
the
10-02_Convert_websocket_transport_to_channel
branch
from
67daefe
to
8076033
Compare
steveluscher
force-pushed
the
10-02-a_channel_augmenter_that_autopings_the_channel
branch
from
0f0bcc7
to
777f244
Compare
steveluscher
force-pushed
the
10-02_Convert_websocket_transport_to_channel
branch
from
8076033
to
74179ea
Compare
steveluscher
force-pushed
the
10-02-a_channel_augmenter_that_autopings_the_channel
branch
from
777f244
to
ef92cee
Compare
steveluscher
force-pushed
the
10-02_Convert_websocket_transport_to_channel
branch
from
74179ea
to
d7ad94e
Compare
steveluscher
force-pushed
the
10-02-a_channel_augmenter_that_autopings_the_channel
branch
from
ef92cee
to
3b665e4
Compare
steveluscher
force-pushed
the
10-02_Convert_websocket_transport_to_channel
branch
from
d7ad94e
to
c295101
Compare
|
Essentially unreviewable PR. Godspeed to us. |
steveluscher
force-pushed
the
10-02-a_channel_augmenter_that_autopings_the_channel
branch
from
3b665e4
to
66ef71c
Compare
steveluscher
force-pushed
the
10-02_Convert_websocket_transport_to_channel
branch
from
c295101
to
e927f6c
Compare
steveluscher
changed the base branch from
10-02-a_channel_augmenter_that_autopings_the_channel
to
10-02-fix_lint_in_version_header
steveluscher
force-pushed
the
10-02-fix_lint_in_version_header
branch
from
5b6a7be
to
ae7672a
Compare
steveluscher
force-pushed
the
10-02_Convert_websocket_transport_to_channel
branch
from
e927f6c
to
100141c
Compare
steveluscher
force-pushed
the
10-02-fix_lint_in_version_header
branch
from
ae7672a
to
b15c26d
Compare
steveluscher
force-pushed
the
10-02_Convert_websocket_transport_to_channel
branch
from
100141c
to
859d964
Compare
steveluscher
force-pushed
the
10-02-fix_lint_in_version_header
branch
2 times, most recently
from
c7c14b0
to
8c25ae3
Compare
steveluscher
force-pushed
the
10-02_Convert_websocket_transport_to_channel
branch
from
859d964
to
7557358
Compare
steveluscher
changed the base branch from
10-02-fix_lint_in_version_header
to
graphite-base/3314
steveluscher
force-pushed
the
graphite-base/3314
branch
from
8c25ae3
to
a419478
Compare
steveluscher
force-pushed
the
10-02_Convert_websocket_transport_to_channel
branch
from
7557358
to
4518435
Compare
steveluscher
force-pushed
the
10-02_Convert_websocket_transport_to_channel
branch
from
4518435
to
c3a3253
Compare
steveluscher
force-pushed
the
10-02_Convert_websocket_transport_to_channel
branch
from
c3a3253
to
6974ccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR swaps out the old transport API for the new one based on transports and channel creators. This pushes the
AsyncIterablecreation right out to the edge of the API, meaning that exactly oneAsyncIterablegets created. At all points before that the pipeline is made up ofDataPublishers.Among other things, this makes cleanup much more straightforward and eliminates several opportunities for memory leaks.
Closes #3090.
Or very nearly so.