Humble corrections #915
Closed
Humble corrections #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ros2#733) Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit c7d3204) Co-authored-by: Tomoya Fujita <[email protected]>
…eader field (ros2#751) * Expand auto to the current time when passed to a Header field Signed-off-by: Esteve Fernandez <[email protected]> * Make sure that the stamp field is updated every time the message is published Signed-off-by: Esteve Fernandez <[email protected]> * Added support for passing 'now' as a value to a 'builtin_interfaces.msg.Time'. Added comments and expand docstring Signed-off-by: Esteve Fernandez <[email protected]> * Only update timestamp fields that have been passed 'now' as a value Signed-off-by: Esteve Fernandez <[email protected]> * Fix lint errors Signed-off-by: Esteve Fernandez <[email protected]> * Added tests Signed-off-by: Esteve Fernandez <[email protected]> * Remove node argument from set_message_fields_expanded Signed-off-by: Esteve Fernandez <[email protected]> * Fix flake8 errors Signed-off-by: Esteve Fernandez <[email protected]> Signed-off-by: Esteve Fernandez <[email protected]>
…os2#757) Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit e9789d4) Co-authored-by: Chris Lalancette <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
* Add support use_sim_time for ros2 topic hz/bw/pub. Signed-off-by: Lei Liu <[email protected]> * Add testcase. Signed-off-by: Lei Liu <[email protected]> * Update code. Signed-off-by: Lei Liu <[email protected]> * Update code again. Signed-off-by: Lei Liu <[email protected]> * Add warning log. Signed-off-by: Lei Liu <[email protected]> * Revert STEADY_TIME. Signed-off-by: Lei Liu <[email protected]> * Fix flake8 warnings. Signed-off-by: Lei Liu <[email protected]> * Update code. Signed-off-by: Lei Liu <[email protected]> Signed-off-by: Lei Liu <[email protected]> Signed-off-by: Tomoya Fujita <[email protected]> Signed-off-by: Lei Liu <[email protected]> Signed-off-by: Tomoya Fujita <[email protected]> Co-authored-by: Lei Liu <[email protected]>
…#784) address flaky test: ros2#772 Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 615efe6) Co-authored-by: Tomoya Fujita <[email protected]>
* NewtorkAwareNode: Fix issue of using old DirectNode in method calls Signed-off-by: Ivan Santiago Paunovic <[email protected]> * NetworkAwareNode: Check all interfaces, not only the gateways Signed-off-by: Ivan Santiago Paunovic <[email protected]> Signed-off-by: Ivan Santiago Paunovic <[email protected]> (cherry picked from commit 70d4991) Co-authored-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
…os2#798) Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit e2adeac) Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
…os2#813) (ros2#815) Otherwise, the 'use_sim_time' parameter we are setting here is completely ignored. Signed-off-by: Chris Lalancette <[email protected]> (cherry picked from commit 08fdf98) Co-authored-by: Chris Lalancette <[email protected]>
"""Dump the parameters of a node to a yaml file.""" -> """Show all of the parameters of a node in a YAML file format.""" Based on the documentation at https://docs.ros.org/en/rolling/How-To-Guides/Using-ros2-param.html#ros2-param-dump Signed-off-by: Murilo M. Marinho <[email protected]> (cherry picked from commit ef5d811) Co-authored-by: Murilo M Marinho <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 0084d12) Co-authored-by: Tomoya Fujita <[email protected]>
…pletion (ros2#852) (ros2#873) * make file handles not inheritable before spawn the daemon Signed-off-by: Chen Lihui <[email protected]> Co-authored-by: Chris Lalancette <[email protected]> (cherry picked from commit d32d820) Co-authored-by: Chen Lihui <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
On Python 3.6 (in RHEL-8), signal.valid_signals() does not exist. Only use it if it exists. Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Scott K Logan <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 305ef76) Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Audrow Nash <[email protected]>
…ros2#888) (ros2#908) * ros2cli.node.daemon : try getting fdsize from /proc for open fd limit * - add with-block; remove linux check * - use removeprefix * - replace filter with loop Signed-off-by: akssri <[email protected]> (cherry picked from commit 64d216c) Co-authored-by: akssri-sony <[email protected]>
|
This is a duplicate of #912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a fdlimit = int(line[len(string_to_find):].strip()) in ros2cli/ros2cli/node/daemon.py replacing use of "removeprefix" as it is supported only from python3.9