Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update daemon.py for Python 3.8 compatibility #912

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Update daemon.py for Python 3.8 compatibility #912

merged 1 commit into from
Jun 24, 2024

Conversation

AhmedMoaz
Copy link

@AhmedMoaz AhmedMoaz commented Jun 16, 2024 •
edited
Loading

Minor fix for containers running Python version < 3.9.0

Before and after:
Fix

Tested on:
environment

@AhmedMoaz
Copy link
Author

Whenever you have a chance, please have a look @clalancette
Related to issue #909

@robmasocco robmasocco mentioned this pull request Jun 17, 2024
Closed
fujitatomoya
fujitatomoya approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix lgtm.

btw, can we apply this patch for all distro? i do not see any downside for doing that. if that is okay, we can target this to rolling and backport all available distros.

fyi: https://docs.python.org/3/library/stdtypes.html#str.removeprefix

@clalancette
Copy link
Contributor

btw, can we apply this patch for all distro? i do not see any downside for doing that. if that is okay, we can target this to rolling and backport all available distros.

I don't think we should do that. This is only a problem on Humble, so we only need the patch there. For everything newer, removeprefix exists and is more readable, in my opinion.

@clalancette clalancette mentioned this pull request Jun 20, 2024
Closed
@AhmedMoaz
Copy link
Author

Let me know if there's anything else needed to get this merged

@fujitatomoya
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@clalancette clalancette merged commit d95532e into ros2:humble Jun 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjo129 arjo129 arjo129 approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AhmedMoaz @clalancette @fujitatomoya @arjo129