-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support package format 3 #197
Conversation
In the current state it does successfully parse all manifest files of ROS 2, exposes an API for all new information as well as provide an API for condition evaluation.
|
7481e0a
to
a805162
Compare
The patch now does utilize the new information in the topological order as well as uses the context to evaluate dependency conditions. @ros-infrastructure/ros_team Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the pyparsing dependency needs to be added to the stdeb.cfg
file too. Other than that lgtm.
I've mentioned this before, but I think it's worth repeating, as long as we're spending time on this, it would benefit us to consolidate the parsing code for package xml files.
… variables to evaluate conditions
Thank you - good catch. I added it here. |
Waiting for a confirmation from @nuclearsandwich before merging... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR allows bloom to release ROS 2 packages that use format 3 manifests.
As defined in REP 149.