Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support package format 3 #197

Merged
merged 2 commits into from
Jan 5, 2018
Merged

support package format 3 #197

merged 2 commits into from
Jan 5, 2018

Conversation

dirk-thomas
Copy link
Member

As defined in REP 149.

@dirk-thomas
Copy link
Member Author

dirk-thomas commented Jan 3, 2018

In the current state it does successfully parse all manifest files of ROS 2, exposes an API for all new information as well as provide an API for condition evaluation.

It doesn't utilize the new information yet in any of the non-parsing API, e.g. consider group dependencies in topological order or passing context for the dependency conditions.

@dirk-thomas dirk-thomas force-pushed the format_3 branch 2 times, most recently from 7481e0a to a805162 Compare January 3, 2018 23:26
@dirk-thomas
Copy link
Member Author

dirk-thomas commented Jan 4, 2018

The patch now does utilize the new information in the topological order as well as uses the context to evaluate dependency conditions.

@ros-infrastructure/ros_team Ready for review.

Copy link
Contributor

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the pyparsing dependency needs to be added to the stdeb.cfg file too. Other than that lgtm.

I've mentioned this before, but I think it's worth repeating, as long as we're spending time on this, it would benefit us to consolidate the parsing code for package xml files.

@dirk-thomas
Copy link
Member Author

I believe the pyparsing dependency needs to be added to the stdeb.cfg file too.

Thank you - good catch. I added it here.

@dirk-thomas
Copy link
Member Author

Waiting for a confirmation from @nuclearsandwich before merging...

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR allows bloom to release ROS 2 packages that use format 3 manifests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants